Diverge tenant config defaults #3822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-gc
approved these changes
Oct 13, 2021
yuchenshi
approved these changes
Oct 14, 2021
This is line is needed to avoid throwing an error on this line: https://github.com/firebase/firebase-admin-node/blob/83fbb6d3ebc2088206a8eb5956326b2198a254e4/src/auth/auth-config.ts#L613
lisajian
force-pushed
the
lj-multitenancy-cleanup2
branch
from
0aadae7 to
f84527b
Compare
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
Diverge in tenant config defaults. Tenant configs default to enabled for implicitly created tenants and default to disabled for explicitly created tenants. Corresponding internal bug: b/192387245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Diverge in tenant config defaults. Tenant configs default to enabled for implicitly created tenants and default to disabled for explicitly created tenants.
Corresponding internal bug: b/192387245
Scenarios Tested
npm testpassesSample Commands
N/A