Skip to content

fix(auth): rename import header to "firebase_auth_messages.g.h". #11472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Aug 15, 2023

Description

Renamed to firebase_auth_messages.g.h so this issue does not continue to reoccur particularly as the regenerated Pigeon file will continue to revert back to messages.g.h.

Related Issues

fixes #11409

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title fix(auth): import header for "messages.g.h" correctly. fix(auth): rename import header to "firebase_auth_messages.h". Aug 16, 2023
@russellwheatley russellwheatley changed the title fix(auth): rename import header to "firebase_auth_messages.h". fix(auth): rename import header to "firebase_auth_messages.g.h". Aug 16, 2023
@russellwheatley russellwheatley merged commit 693a6f3 into master Aug 16, 2023
@russellwheatley russellwheatley deleted the auth-11409 branch August 16, 2023 12:44
khanliKU pushed a commit to khanliKU/flutterfire that referenced this pull request Aug 18, 2023
@firebase firebase locked and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_auth 4.7.2] Build fails with 'messages.g.h' file not found
4 participants