Skip to content

[CI] Skip flaky firebase_performance driver tests #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kroikie merged 4 commits into from
Nov 19, 2019
Merged

[CI] Skip flaky firebase_performance driver tests #1452

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c264fc5
Skip flaky firebase_performance driver tests
kroikie Nov 18, 2019
7e6c51f
bump version
kroikie Nov 19, 2019
32de892
update version number
kroikie Nov 19, 2019
a63566c
Add todo to fix tests
kroikie Nov 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/firebase_performance/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.3.1+4

* Skip flaky driver tests. Track updating tests [here](https://github.com/FirebaseExtended/flutterfire/issues/1454).

## 0.3.1+3

* Fixed analyzer warnings about unused fields.
Expand Down
16 changes: 8 additions & 8 deletions packages/firebase_performance/example/test_driver/firebase_performance.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,14 @@ void main() {

testTrace.incrementMetric('metric', 45);
expect(testTrace.getMetric('metric'), completion(59));
});
}, skip: true);

test('setMetric', () {
testTrace.start();

testTrace.setMetric('metric2', 37);
expect(testTrace.getMetric('metric2'), completion(37));
});
}, skip: true);

test('putAttribute', () {
testTrace.putAttribute('apple', 'sauce');
Expand All @@ -86,7 +86,7 @@ void main() {
testTrace.getAttributes(),
completion(<String, String>{'apple': 'sauce', 'banana': 'pie'}),
);
});
}, skip: true);

test('removeAttribute', () {
testTrace.putAttribute('sponge', 'bob');
Expand All @@ -97,7 +97,7 @@ void main() {
testTrace.getAttributes(),
completion(<String, String>{'patrick': 'star'}),
);
});
}, skip: true);

test('getAttributes', () {
testTrace.putAttribute('yugi', 'oh');
Expand All @@ -114,7 +114,7 @@ void main() {
completion(<String, String>{'yugi': 'oh'}),
);
});
});
}, skip: true);

group('$HttpMetric', () {
HttpMetric testMetric;
Expand All @@ -138,7 +138,7 @@ void main() {
testMetric.getAttributes(),
completion(<String, String>{'apple': 'sauce', 'banana': 'pie'}),
);
});
}, skip: true);

test('removeAttribute', () {
testMetric.putAttribute('sponge', 'bob');
Expand All @@ -149,7 +149,7 @@ void main() {
testMetric.getAttributes(),
completion(<String, String>{'patrick': 'star'}),
);
});
}, skip: true);

test('getAttributes', () {
testMetric.putAttribute('yugi', 'oh');
Expand All @@ -165,7 +165,7 @@ void main() {
testMetric.getAttributes(),
completion(<String, String>{'yugi': 'oh'}),
);
});
}, skip: true);

test('http setters shouldn\'t cause a crash', () async {
testMetric.start();
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_performance/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Flutter plugin for Google Performance Monitoring for Firebase, an a
iOS.
author: Flutter Team <[email protected]>
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_performance
version: 0.3.1+3
version: 0.3.1+4

dependencies:
flutter:
Expand Down