Skip to content

[cloud_firestore] Fix test that used FirebaseApp.channel #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2019
Merged

[cloud_firestore] Fix test that used FirebaseApp.channel #1476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63ec0db
[cloud_firestore] Fix test that used FirebaseApp.channel
harryterkelsen Nov 21, 2019
04c133f
dartfmt
harryterkelsen Nov 21, 2019
efe38f0
bump version
harryterkelsen Nov 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/cloud_firestore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.12.10+3

* Fixed test that used `FirebaseApp.channel`.

## 0.12.10+2

* Fixed analyzer warnings about unused fields.
Expand Down
2 changes: 1 addition & 1 deletion packages/cloud_firestore/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for Cloud Firestore, a cloud-hosted, noSQL database
live synchronization and offline support on Android and iOS.
author: Flutter Team <[email protected]>
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/cloud_firestore
version: 0.12.10+2
version: 0.12.10+3

flutter:
plugin:
Expand Down
5 changes: 4 additions & 1 deletion packages/cloud_firestore/test/cloud_firestore_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,13 @@ void main() {
"hasPendingWrites": false,
"isFromCache": false,
};
const MethodChannel firebaseCoreChannel =
MethodChannel('plugins.flutter.io/firebase_core');

setUp(() async {
mockHandleId = 0;
// Required for FirebaseApp.configure
FirebaseApp.channel.setMockMethodCallHandler(
firebaseCoreChannel.setMockMethodCallHandler(
(MethodCall methodCall) async {},
);
app = await FirebaseApp.configure(
Expand Down