Skip to content

[cloud_functions] Make HttpsCallable.call async #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cubuspl42
Copy link
Contributor

Description

Previously the catch blocks would never execute, because the function returned Future<HttpsCallableResult> synchronously. CloudFunctionsException couldn't be thrown.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Previously the `catch` blocks would never execute, because the function returned `Future<HttpsCallableResult>` synchronously. `CloudFunctionsException` couldn't be thrown.
@cubuspl42
Copy link
Contributor Author

I'm closing in favour of #2556

@cubuspl42 cubuspl42 closed this Sep 1, 2020
@cubuspl42
Copy link
Contributor Author

Relevant issue: #2069

@firebase firebase locked and limited conversation to collaborators Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants