Skip to content

fix(go/core): log action name in slog #3637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

fix(go/core): log action name in slog #3637

merged 1 commit into from
Sep 26, 2025

Conversation

@janishorsts
Copy link
Contributor

@janishorsts janishorsts commented Sep 25, 2025 •
edited
Loading

Fixes #3643

slog prints a debug message with the memory address of the function ActionDef.Name.

ActionDef.Name is a function, not a string type.

// Name returns the Action's Name.
func (a *ActionDef[In, Out, Stream]) Name() string { return a.desc.Name }

Current

2025/09/25 17:56:08 DEBUG Action.Run name=0x102e32910 ...

Expected

2025/09/25 17:56:08 DEBUG Action.Run name=getWeather ...

Checklist (if applicable):

@janishorsts janishorsts changed the title fix: log action name in slog fix(go/core): log action name in slog Sep 25, 2025
@hugoaguirre hugoaguirre merged commit 7fff791 into firebase:main Sep 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugoaguirre hugoaguirre hugoaguirre approved these changes

Assignees

No one assigned

Labels

fix go

Projects

Genkit Backlog
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Go] log prints memory address of the ActionDef.Name func

2 participants

@janishorsts @hugoaguirre