fix(js): duplicate sample project names#4578
Conversation
Summary of ChangesHello @yesudeep, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves naming inconsistencies across various JavaScript test applications by updating their Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses an issue with duplicate project names across several package.json files for the JavaScript test applications. The changes correctly update the name field in each file to be unique and more descriptive of the specific test app's purpose. This is a good practice that improves maintainability and prevents potential package name conflicts. The changes are accurate and well-contained.
36f833a to
d807631
Compare
This PR updates the
package.jsonnames for several JS test apps to resolve duplicate project name issues.Changes
js/testapps/ollama:basic-gemini->basic-ollamajs/testapps/rag:rag->rag-testappjs/testapps/vertexai-vector-search-bigquery:vertex-vector-search->vertex-vector-search-bigqueryjs/testapps/vertexai-vector-search-custom:vertex-vector-search->vertex-vector-search-customjs/testapps/vertexai-vector-search-firestore:vertex-vector-search->vertex-vector-search-firestore