Skip to content

CachedKeySet should use an uppercase GET method with PSR HttpClient #447

Closed
@noemi-salaun

Description

@noemi-salaun

In the class CachedKeySet, the http request is created with a lowercase get method.
Standard HTTP method defined in the RFC are all uppercase and PSR HttpClient are explicitly asked not to modify the case because methods are case sensitive.

See https://www.php-fig.org/psr/psr-7/

 * While HTTP method names are typically all uppercase characters, HTTP
 * method names are case-sensitive and thus implementations SHOULD NOT
 * modify the given string.

Some HttpClient implementation, like the one from Symfony prevent the use of lowercase method name, so we cannot use them as ClientInterface for the CachedKeySet

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions