-
Notifications
You must be signed in to change notification settings - Fork 1.3k
update README.md #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update README.md #299
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
README.md
Outdated
// you can convert JWK to PEM with Firebase\JWT\JWK::parseKeySet(). | ||
|
||
/** @var array<string,Resource> $convertedKeys array key is key id(kid), and value is Openssl Resource */ | ||
$convertedKeys = JWT::parseKeySet($keys); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to point out a typo here that could cause confusion.
$convertedKeys = JWT::parseKeySet($keys); | |
$convertedKeys = JWK::parseKeySet($keys); |
The readme now has an example of using JWKs! So I believe this is now a duplicate of #307 |
Now, this library supporting JWK in #273 but I could not find it in document.
sorry for my poor English.
if added example don't make sence, please tell me and will fix it.