Skip to content

update README.md #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

kiridaruma
Copy link

Now, this library supporting JWK in #273 but I could not find it in document.

sorry for my poor English.
if added example don't make sence, please tell me and will fix it.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kiridaruma
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jun 5, 2020
README.md Outdated
// you can convert JWK to PEM with Firebase\JWT\JWK::parseKeySet().

/** @var array<string,Resource> $convertedKeys array key is key id(kid), and value is Openssl Resource */
$convertedKeys = JWT::parseKeySet($keys);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to point out a typo here that could cause confusion.

Suggested change
$convertedKeys = JWT::parseKeySet($keys);
$convertedKeys = JWK::parseKeySet($keys);

@bshaffer
Copy link
Collaborator

The readme now has an example of using JWKs! So I believe this is now a duplicate of #307

@bshaffer bshaffer closed this May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants