Skip to content

Add ext-sodium to improve suggest block #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 19, 2022
Merged

Add ext-sodium to improve suggest block #474

merged 3 commits into from
Dec 19, 2022

Conversation

peter279k
Copy link

Changed log

  • Before PHP 7.2 version is released, the sodium extension is not included in the core PHP extension, it can also add the ext-sodium extension in the suggest block to remind developers when using the PHP 7.0 and PHP 7.1 versions.

bshaffer
bshaffer approved these changes Dec 19, 2022
View reviewed changes
@bshaffer bshaffer enabled auto-merge (squash) December 19, 2022 22:06
@bshaffer bshaffer merged commit 0178679 into firebase:main Dec 19, 2022
@peter279k peter279k deleted the improve_suggest_block branch December 20, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter279k @bshaffer