Skip to content

Update model to 1.5-pro #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024
Merged

Update model to 1.5-pro #1611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...p/src/main/kotlin/com/google/firebase/quickstart/vertexai/GenerativeAiViewModelFactory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,17 @@ val GenerativeViewModelFactory = object : ViewModelProvider.Factory {
// Initialize a GenerativeModel with the `gemini-pro` AI model
// for text generation
val generativeModel = Firebase.vertexAI.generativeModel(
modelName = "gemini-1.0-pro",
modelName = "gemini-1.5-pro-preview-0409",
generationConfig = config
)
SummarizeViewModel(generativeModel)
}

isAssignableFrom(PhotoReasoningViewModel::class.java) -> {
// Initialize a GenerativeModel with the `gemini-pro-vision` AI model
// Initialize a GenerativeModel with the `gemini-pro` AI model
// for multimodal text generation
val generativeModel = Firebase.vertexAI.generativeModel(
modelName = "gemini-1.0-pro-vision",
modelName = "gemini-1.5-pro-preview-0409",
generationConfig = config
)
Comment on lines +56 to 61
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point I think we can initialize the model once (like before the return clause) and then pass to every ViewModel. The reason why I had different initializations was because of gemini-pro-vision. But now that we use the same model for every use case, maybe we could simplify our code?

PhotoReasoningViewModel(generativeModel)
Expand All @@ -65,7 +65,7 @@ val GenerativeViewModelFactory = object : ViewModelProvider.Factory {
isAssignableFrom(ChatViewModel::class.java) -> {
// Initialize a GenerativeModel with the `gemini-pro` AI model for chat
val generativeModel = Firebase.vertexAI.generativeModel(
modelName = "gemini-1.0-pro",
modelName = "gemini-1.5-pro-preview-0409",
generationConfig = config
)
ChatViewModel(generativeModel)
Expand All @@ -89,7 +89,7 @@ val GenerativeViewModelFactory = object : ViewModelProvider.Factory {

// Initialize a GenerativeModel with the `gemini-pro` AI model for function calling chat
val generativeModel = Firebase.vertexAI.generativeModel(
modelName = "gemini-1.0-pro",
modelName = "gemini-1.5-pro-preview-0409",
generationConfig = config,
tools = tools
)
Expand Down
Loading