feat: create Firebase AI quickstart#2667
Merged
thatfiredev merged 52 commits intomasterfrom May 20, 2025
Merged
Conversation
| textAlign = TextAlign.End, | ||
| modifier = Modifier | ||
| .background(backgroundColor.copy( | ||
| red = backgroundColor.red * 0.7f, |
Contributor
There was a problem hiding this comment.
Suggestion: create color variables in Color.kt and add the transparency using hex color code.
Member
Author
There was a problem hiding this comment.
The backgroundColor property here is dynamic and it changes according to the color set at the OS-level, so it can't really be hardcoded into Color.kt.
val backgroundColor = when (chatMessage.role) {
"user" -> MaterialTheme.colorScheme.tertiaryContainer
else -> MaterialTheme.colorScheme.secondaryContainer
}
marinacoelho
requested changes
May 19, 2025
Contributor
marinacoelho
left a comment
There was a problem hiding this comment.
This is looking very good! Just left a few comments (not all of them are blockers). We should also add a README before merging it :)
rlazo
approved these changes
May 20, 2025
a123ab4 to
2932ba4
Compare
marinacoelho
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI will fail at the moment, since
the SDK has not been released yet. I will make sure it's green after the SDK is released and only merge by then.Fast follows: