-
Notifications
You must be signed in to change notification settings - Fork 7.4k
feat: create Firebase AI quickstart #2667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
textAlign = TextAlign.End, | ||
modifier = Modifier | ||
.background(backgroundColor.copy( | ||
red = backgroundColor.red * 0.7f, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: create color variables in Color.kt
and add the transparency using hex color code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backgroundColor
property here is dynamic and it changes according to the color set at the OS-level, so it can't really be hardcoded into Color.kt
.
val backgroundColor = when (chatMessage.role) {
"user" -> MaterialTheme.colorScheme.tertiaryContainer
else -> MaterialTheme.colorScheme.secondaryContainer
}
ai/app/src/main/java/com/google/firebase/quickstart/ai/ui/navigation/FirebaseAISamples.kt
Outdated
Show resolved
Hide resolved
ai/app/src/main/java/com/google/firebase/quickstart/ai/ui/navigation/MainMenuScreen.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking very good! Just left a few comments (not all of them are blockers). We should also add a README before merging it :)
a123ab4
to
2932ba4
Compare
CI will fail at the moment, since
the SDK has not been released yet. I will make sure it's green after the SDK is released and only merge by then.Fast follows: