refactor(admob): add snippets from quickstart-android #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
reviewed
Jan 14, 2021
| MobileAds.initialize(context); | ||
|
|
||
| // [START load_banner_ad] | ||
| AdRequest adRequest = new AdRequest.Builder().build(); |
There was a problem hiding this comment.
Is there a reason all of these snippets are in the onCreate function instead of in helper functions? Having most snippets live in their own function is generally easier to maintain, especially when they don't need to refer to each other's results/variables.
There was a problem hiding this comment.
Sounds good. And that actually leaves our onCreate snippet untouched.
I've updated the PR.
samtstern
approved these changes
Jan 14, 2021
|
@rosariopfernandes this is great thank you! I'll make the changes on the doc site to point to these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in firebase/quickstart-android#1247, we're moving the admob snippets to this repo.
Snippets added in this PR:
There are snippets in AndroidManifest.xml which were kept in the quickstarts repo.
I also noticed that the
AdListener.onAdFailedToLoad(int)method used here was deprecated in favor ofAdListener.onAdFailedToLoad(LoadAdError), so I replaced it.