Skip to content

Add v8 and v9 snippets for Handling the account-exists-with-different… #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

NhienLam
Copy link
Contributor

Add v9 snippets for https://cloud.google.com/identity-platform/docs/link-accounts#handling_the_account-exists-with-different-credential_error.

Remove the usage of fetchSignInMethodsForEmail from the existing snippet in the public doc because it was deprecated due to email enumeration concerns.

const method = promptUserForSignInMethod();

if (method === 'password') {
// TODO: Ask the user for their password.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was from the existing snippet. I think this is to tell developers to implement promptUserForPassword so let's keep it.

@NhienLam NhienLam merged commit 1abb6ce into master Apr 12, 2024
5 checks passed
@NhienLam NhienLam deleted the link-accounts branch April 12, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants