Skip to content

Updating network interfaces returns 400 Bad Request #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alxiord opened this issue Jun 15, 2018 · 0 comments
Closed

Updating network interfaces returns 400 Bad Request #354

alxiord opened this issue Jun 15, 2018 · 0 comments
Labels
Type: Bug Indicates an unexpected problem or unintended behavior

Comments

@alxiord
Copy link

alxiord commented Jun 15, 2018

PUT /network-interfaces before guest boot returns 400 when attempting to update the MAC.

curl --unix-socket /tmp/firecracker.socket -i \
      -X PUT "http://localhost/network-interfaces/1" \
      -H "accept: application/json" \
      -H "Content-Type: application/json" \
      -d "{ 
             \"iface_id\": \"1\", 
             \"host_dev_name\": \"vmtap33\", 
             \"guest_mac\": \"06:00:00:00:00:01\", 
             \"state\": \"Attached\" 
         }"
HTTP/1.1 201 Created
Content-Length: 0
Date: Fri, 15 Jun 2018 12:39:47 GMT

curl --unix-socket /tmp/firecracker.socket -i\
      -X PUT "http://localhost/network-interfaces/1"\
      -H "accept: application/json"\
      -H "Content-Type: application/json"\
      -d "{ 
            \"iface_id\": \"1\", 
            \"host_dev_name\": \"vmtap33\", 
            \"guest_mac\": \"06:00:00:00:00:02\", 
            \"state\": \"Attached\" 
        }"
HTTP/1.1 400 Bad Request
Content-Type: application/json
Transfer-Encoding: chunked
Date: Fri, 15 Jun 2018 12:39:52 GMT

{
  "fault_message": "Could not open TAP device."
}
@alxiord alxiord added the Type: Bug Indicates an unexpected problem or unintended behavior label Jun 15, 2018
@alxiord alxiord added this to the Customer 2 Production milestone Jun 15, 2018
@alxiord alxiord mentioned this issue Jun 15, 2018
@alxiord alxiord self-assigned this Jun 18, 2018
acatangiu pushed a commit that referenced this issue Jun 28, 2018
The network interfaces update test case only covered interface name
update, which worked because a new tap device was created. See #354

Signed-off-by: Alexandra Iordache <[email protected]>
xibz pushed a commit to xibz/firecracker that referenced this issue Dec 4, 2018
Changing the MAC address resulted in error 400 because the inner tap
object was already taken. Added support to leave the tap in place and
update the other fields, unless the interface's name changes.

Fixes firecracker-microvm#354

Signed-off-by: Alexandra Iordache <[email protected]>
xibz pushed a commit to xibz/firecracker that referenced this issue Dec 4, 2018
The network interfaces update test case only covered interface name
update, which worked because a new tap device was created. See firecracker-microvm#354

Signed-off-by: Alexandra Iordache <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant