Update Rust toolchain to 1.46.0 #2323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Catangiu <[email protected]>
Signed-off-by: Adrian Catangiu <[email protected]>
Signed-off-by: Diana Popa <[email protected]>
Upon exec, a mprotect call is triggered. Since this syscall is not whitelisted the CI would fail with "Bad System Call". This is needed only in the CI. Signed-off-by: Diana Popa <[email protected]>
dianpopa
force-pushed
the
rust-vers-bump
branch
from
bface3b to
7bfd66a
Compare
georgepisaltu
approved these changes
Dec 9, 2020
| @@ -18,7 +18,7 @@ pub(crate) fn compact_page_frame_numbers(v: &mut Vec<u32>) -> Vec<(u32, u32)> { | |||
| // received at once from a single descriptor is `MAX_PAGES_IN_DESC`, | |||
| // this sort does not change the complexity of handling | |||
| // an inflation. | |||
| v.sort(); | |||
| v.sort_unstable(); | |||
| @@ -4,8 +4,7 @@ FROM ubuntu:18.04 | |||
| # The Rust toolchain layer will get updated most frequently, but we could keep the system | |||
| # dependencies layer intact for much longer. | |||
|
|
|||
| ARG RUST_TOOLCHAIN="1.43.1" | |||
| ARG RUST_TOOLCHAIN_AUDIT="1.47.0" | |||
There was a problem hiding this comment.
Does this change mean auditing will always be done with the latest stable version (instead of the previously hard-coded value)?
| @@ -23,7 +23,7 @@ | |||
| # this contains the frequency while on AMD it does not. | |||
| # Checkout the cpuid crate. In the future other | |||
| # differences may appear. | |||
| COVERAGE_DICT = {"Intel": 85.25, "AMD": 84.50, "ARM": 82.72} | |||
| COVERAGE_DICT = {"Intel": 85.04, "AMD": 84.27, "ARM": 82.98} | |||
There was a problem hiding this comment.
x86 coverage dropping while the ARM one is rising. Maybe they are trending towards the mean value?
luminitavoicu
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Ideally we would update to the latest stable which is
1.48.0- which has also promotedaarch64-unknown-linux-muslto Tier 2.Unfortunately that's not possible because of compiler and linker issues rust-lang/rust#79789 and rust-lang/rust#79791.
Latest stable we can use now is
1.46.0- the version targeted by this PR.Binary size decreases along with covered lines because of aggressive LTO code deduplication.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).Any required documentation changes (code and docs) are included in this PR.Any newly addedunsafecode is properly documented.Any API changes are reflected infirecracker/swagger.yaml.Any user-facing changes are mentioned inCHANGELOG.md.