Update changelog for release v0.5.0 #352

alxiord · 2018-06-15T11:06:35Z

No description provided.

acatangiu · 2018-06-15T11:20:09Z

CHANGELOG.md

+* In case of failure, the metrics and the panic location are logged before aborting.
+* A CPU features template for C3 is available, in addition to the one for T2.
+* Seccomp filters restrict Firecracker from calling any other system calls than the minimum set it needs to function properly. The filters are enabled by setting the `USE_SECCOMP` environment variable to 1 before running Firecracker.
+* Firecracker is started by a new binary called `jailer`. The jailer takes as command line arguments a unique ID, the path to the Firecracker binary, and a uid and gid for Firecracker to run as. It sets up a chroot environment and a cgroup and calls exec to morph into Firecracker.


typo: s/a unique ID/an unique ID

I think I would rephrase it to Firecracker can be started. We are not actually enforcing firecracker to be started by the jailer.

It's not a typo; phonetically, the word "unique" starts with a consonant as the letter "u" is pronounced "yu" (unlike "umbrella", for instance, where it's pronounced as a vowel). See http://www.writersdigest.com/online-editor/a-before-consonants-and-an-before-vowels-is-not-the-rule

Rephrased to "can be"

Schooled 🔥

andreeaflorescu · 2018-06-15T11:40:30Z

CHANGELOG.md

+
+* API requests, VCPU and device actions for the serial console (UART), keyboard (i8042), block and network devices are logged as metrics.
+* Metrics are logged every 60 seconds.
+* In case of failure, the metrics and the panic location are logged before aborting.


This should be in the Fixed section.

andreeaflorescu · 2018-06-15T11:41:24Z

CHANGELOG.md

+### Added
+
+* API requests, VCPU and device actions for the serial console (UART), keyboard (i8042), block and network devices are logged as metrics.
+* Metrics are logged every 60 seconds.


I would rephrase the previous 2 bullets as 1. Something that says: added a metrics system, added metrics for x, y, z. These metrics are logged every 60 seconds. We should have one bullet for one feature and these seem to both refer to the same thing.

andreeaflorescu · 2018-06-15T11:45:00Z

CHANGELOG.md

+
+### Changed
+
+* The metric implementation uses lockless operations on atomic variables.


This one is not customer facing, we should remove it.

andreeaflorescu · 2018-06-15T11:45:20Z

CHANGELOG.md

+
+* The metric implementation uses lockless operations on atomic variables.
+* Metric values are reset with every flush.
+* Renamed `cpuid.rs` to `cpuid/mod.rs`.


All 3 entries related to cpuid (except renaming the CPUTemplate) are not customer facing and should not be in the changelog.

andreeaflorescu · 2018-06-15T11:47:05Z

CHANGELOG.md

+
+### Removed
+
+* Removed a leftover file generated by the logger unit tests.


We should also say that we removed firecracker-v0.1.0.yaml. The PR was just merged.

andreeaflorescu · 2018-06-15T11:47:44Z

CHANGELOG.md

+* Firecracker is started by a new binary called `jailer`. The jailer takes as command line arguments a unique ID, the path to the Firecracker binary, and a uid and gid for Firecracker to run as. It sets up a chroot environment and a cgroup and calls exec to morph into Firecracker.
+
+### Changed
+


Just merged a PR that renames firecracker-beta.yaml to firecracker.yaml. This should be here somewhere.

Added a bullet for this change.

andreeaflorescu · 2018-06-15T11:48:37Z

CHANGELOG.md

+* In case of failure, the metrics and the panic location are logged before aborting.
+* A CPU features template for C3 is available, in addition to the one for T2.
+* Seccomp filters restrict Firecracker from calling any other system calls than the minimum set it needs to function properly. The filters are enabled by setting the `USE_SECCOMP` environment variable to 1 before running Firecracker.
+* Firecracker is started by a new binary called `jailer`. The jailer takes as command line arguments a unique ID, the path to the Firecracker binary, and a uid and gid for Firecracker to run as. It sets up a chroot environment and a cgroup and calls exec to morph into Firecracker.


I think I would rephrase it to Firecracker can be started. We are not actually enforcing firecracker to be started by the jailer.

dianpopa · 2018-06-15T12:49:31Z

CHANGELOG.md

+* Added metrics for API requests, VCPU and device actions for the serial console (UART), keyboard (i8042), block and network devices. Metrics are logged every 60 seconds.
+* A CPU features template for C3 is available, in addition to the one for T2.
+* Seccomp filters restrict Firecracker from calling any other system calls than the minimum set it needs to function properly. The filters are enabled by setting the `USE_SECCOMP` environment variable to 1 before running Firecracker.
+* Firecracker can be started by a new binary called `jailer`. The jailer takes as command line arguments a unique ID, the path to the Firecracker binary, and a uid and gid for Firecracker to run as. It sets up a chroot environment and a cgroup and calls exec to morph into Firecracker.


Should something follow after: to run as?

I meant to say that Firecracker will run as a process with the specified uid and gid, so no - but if it sounds weird, I'll change that.

Fixes #352 Signed-off-by: Alexandra Iordache <[email protected]>

Fixes firecracker-microvm#352 Signed-off-by: Alexandra Iordache <[email protected]>

acatangiu previously approved these changes Jun 15, 2018

View reviewed changes

andreeaflorescu suggested changes Jun 15, 2018

View reviewed changes

alxiord dismissed acatangiu’s stale review via 3915752 June 15, 2018 12:17

dianpopa assigned alxiord Jun 15, 2018

andreeaflorescu previously approved these changes Jun 15, 2018

View reviewed changes

alxiord dismissed andreeaflorescu’s stale review via 167b9a0 June 15, 2018 12:54

dianpopa reviewed Jun 15, 2018

View reviewed changes

andreeaflorescu previously approved these changes Jun 15, 2018

View reviewed changes

Release notes for Firecracker v0.5.0

e84582d

Fixes #352 Signed-off-by: Alexandra Iordache <[email protected]>

alxiord dismissed andreeaflorescu’s stale review via e84582d June 15, 2018 13:20

alxiord closed this in 149b917 Jun 15, 2018

alxiord deleted the readme branch June 18, 2018 07:44

hyandell unassigned alxiord Nov 7, 2018

xibz pushed a commit to xibz/firecracker that referenced this pull request Dec 4, 2018

Release notes for Firecracker v0.5.0

b3a476d

Fixes firecracker-microvm#352 Signed-off-by: Alexandra Iordache <[email protected]>


		### Changed

		* The metric implementation uses lockless operations on atomic variables.


		### Removed

		* Removed a leftover file generated by the logger unit tests.

		* Firecracker is started by a new binary called `jailer`. The jailer takes as command line arguments a unique ID, the path to the Firecracker binary, and a uid and gid for Firecracker to run as. It sets up a chroot environment and a cgroup and calls exec to morph into Firecracker.

		### Changed

Update changelog for release v0.5.0 #352

Update changelog for release v0.5.0 #352

Uh oh!

Conversation

alxiord commented Jun 15, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!