fix(swagger): document 204 response for free page hinting start/stop#5884
Merged
Conversation
The PATCH /balloon/hinting/start and PATCH /balloon/hinting/stop endpoints return 204 No Content on success (their VmmAction handlers map to VmmData::Empty, which the API server converts to StatusCode::NoContent), but the OpenAPI spec declared 200. Signed-off-by: Nikita Kalyazin <nikita.kalyazin@e2b.dev>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5884 +/- ##
=======================================
Coverage 82.90% 82.90%
=======================================
Files 277 277
Lines 30053 30053
=======================================
Hits 24914 24914
Misses 5139 5139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JackThomson2
approved these changes
May 14, 2026
JackThomson2
added
the
Status: Awaiting review
Manciukic
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The PATCH /balloon/hinting/start and PATCH /balloon/hinting/stop endpoints return 204 No Content on success (their VmmAction handlers map to VmmData::Empty, which the API server converts to StatusCode::NoContent), but the OpenAPI spec declared 200.
Reason
Mismatch between the code and spec.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.[ ] If a specific issue led to this PR, this PR closes the issue.[ ] When making API changes, I have followed theRunbook for Firecracker API changes.
[ ] I have tested all new and changed functionalities in unit tests and/orintegration tests.
[ ] I have linked an issue to every newTODO.rust-vmm.