Update UFL element interface: move elements to FInAT #3166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2023
This was referenced Nov 7, 2023
dham
previously requested changes
Nov 8, 2023
Member
dham
left a comment
dham
left a comment
There was a problem hiding this comment.
There are minor things but there is also HDiv -> HDivElement which is a breaking API change that we can't make without warning.
This reverts commit 247fe16.
mscroggs
commented
Nov 8, 2023
Contributor
Author
|
I've fixed the behaviour of |
ReubenHill
reviewed
Nov 15, 2023
connorjward
reviewed
Nov 15, 2023
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
99% fine. Happy to approve once my comments are addressed.
This reverts commit af681f6.
JDBetteridge
requested changes
Nov 15, 2023
Member
JDBetteridge
left a comment
JDBetteridge
left a comment
There was a problem hiding this comment.
Don't worry about adding these I'll add the suggestions to a batch once I've checked the other branches 🙂
JDBetteridge
approved these changes
Nov 15, 2023
Member
|
Thanks for all your hard work on this @mscroggs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of #3122.
In FInAT/FInAT#111, I moved the elements from
ufl.legacytofinat.ufl. This PR updates tsfc to use the elements from there.This is all a consequence of FEniCS/ufl#197.
(I've left #3122 up too for now in case this extension is not wanted.)
This PR is coupled with firedrakeproject/ufl#46,
firedrakeproject/tsfc#302 (merged),FInAT/FInAT#111 (merged), andNGSolve/ngsPETSc#7 (merged).