Skip to content

Conversation

@MiloszFilimowski
Copy link
Collaborator

Description

Motivation and Context

WebRTC bump was needed for #170

How has this been tested?

  • Tested if camera preview works on iOS.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@linear
Copy link

linear bot commented Oct 23, 2024

@MiloszFilimowski MiloszFilimowski marked this pull request as ready for review October 23, 2024 15:48
Copy link
Contributor

@mironiasty mironiasty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👏

we ever need to support multi-cam,

I don't expect this will be a case anytime soon. And if so, we will have few other issues anyway 🤷

@MiloszFilimowski MiloszFilimowski merged commit ed207d9 into main Oct 24, 2024
@MiloszFilimowski MiloszFilimowski deleted the mfilimowski/FCE-683-fix-webrtc-bump branch October 24, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants