Fold in accounting_periods passthrough columns #64
+77
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite and netsuite2
…_through_macros_to_accounting_periods_model
…ccounting_periods_model Adding fill_pass_through_columns to accounting_periods model in netsu…
There was a problem hiding this comment.
@fivetran-jamie Looks mostly good! Before approving, I'm wondering if we should create a tiny PR (no release) on dbt_netsuite to incorporate some of the below suggestions. Let me know your thoughts.
Co-authored-by: Avinash Kunnath <[email protected]>
…com/fivetran/dbt_netsuite_source into feature/accounting-periods-passthru
fivetran-avinash
approved these changes
Jul 2, 2025
fivetran-catfritz
approved these changes
Jul 3, 2025
Co-authored-by: fivetran-catfritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
v0.13.1
This PR addresses the following Issue/Feature(s):
Polishes #62 for release
Summary of changes:
Adds passthrough column variable for accounting periods. This will not be used downstream in the transform models for the time being
Submission Checklist
Alignment meeting with the reviewer (if needed)
Provide validation details:
This does not require a transform PR, but validation tests pass when pointing to this source package branch
Will provide screenshots in Height
Changelog