Consolidate source + remove tests#178

Merged

fivetran-avinash merged 16 commits intomainfrom

MagicBot/consolidate-source-package

Oct 2, 2025

Contributor

fivetran-data-model-bot commented Sep 23, 2025 •

edited by fivetran-avinash

Loading

Summary

This PR is to combine the source and transform packages and remove tests not compatible with dbt Fusion 1.10.6+.

Please check the below automated updates were successful:

MANUAL UPDATES

If applicable, merge in the Q2 FY26 Automatic Package Updates PR.
If there are 2 docs.md files, consolidate the definitions the file in the main folder and remove the 2nd file.
Scan the README for non-standard references to the source package and remove or update.
Copy the passthrough vars or other non-standard vars from the source dbt_project.yml to the transform dbt_project.yml.
Check BK run logs for at least 2 warehouses
- No further deprecation warnings
- No union data "table not found" type warnings
Make sure below automatic updates were applied correctly.

Source + Transform Consolidation

Moved models/macros to models/staging/ and macros/staging/.
Updated all var('') references within models to use ref('stg_quickbooks__').
Updated vars in dbt_project.yml from refs to sources.
Removed the source package from packages.yml.
Major version bump to v1.0.0 (or higher if applicable)

YAML & Config Updates

Added +schema and +materialization for the staging models in dbt_project.yml.

README

Removed references to the source package in:
- Overview
- Installation instructions
- Dependencies list
- Schema override examples


          Consolidate dbt source into transform

cf25e09

fivetran-data-model-bot added the next-release label

fivetran-avinash self-assigned this

fivetran-avinash added 3 commits

September 24, 2025 10:55


          Source consolidation updates

1e85728


          docs.md

5ba7a7c


          docs.md

aefc89a

fivetran-joemarkiewicz self-requested a review

September 29, 2025 18:15

fivetran-avinash added 4 commits

September 29, 2025 23:52


          Tax line additions


          seed error

6696b4d


          seed error

1da5597


          CHANGELOG

c6a9c6e

fivetran-avinash added the docs:ready label


          docs

345d601

fivetran-avinash added docs:ready and removed docs:ready labels

github-actions bot and others added 4 commits

September 30, 2025 15:21


          Generate dbt docs via GitHub Actions

aa19e77


          Generate dbt docs via GitHub Actions

d5ebd5a


          schema bump

f9f516c


          Merge branch 'MagicBot/consolidate-source-package' of https://github.…

36a2fdf

…com/fivetran/dbt_quickbooks into MagicBot/consolidate-source-package

fivetran-joemarkiewicz requested changes

View reviewed changes

Contributor

fivetran-joemarkiewicz left a comment

@fivetran-avinash a few comments change requests before approval. Thanks for working through this update!

DECISIONLOG.md Outdated

CHANGELOG.md Outdated

CHANGELOG.md

CHANGELOG.md

CHANGELOG.md Outdated

CHANGELOG.md Outdated

README.md Outdated

models/double_entry_transactions/int_quickbooks__invoice_double_entry.sql

integration_tests/tests/consistency/consistency_general_ledger.sql Outdated

integration_tests/tests/consistency/consistency_general_ledger.sql Outdated

fivetran-avinash linked an issue

that may be closed by this pull request

Consolidate quickbooks_source package into here #177

Closed


          PR review

83e4a2b

fivetran-avinash reviewed

View reviewed changes

Contributor

fivetran-avinash left a comment

@fivetran-joemarkiewicz Ready for re-review! One question around your limit 1 issue.


          README/DECISIONLOG updates

1a9371f

fivetran-joemarkiewicz approved these changes

View reviewed changes

Contributor

fivetran-joemarkiewicz left a comment

LGTM with small requests to bring the schema name back to the original and also regenerate the docs. Once those updates are applied, this will be ready to go!

integration_tests/dbt_project.yml Outdated

    
                quickbooks_source:

                  quickbooks_schema: quickbooks_integration_tests_21

                quickbooks:

                  quickbooks_schema: quickbooks_integration_tests_22

Contributor

fivetran-joemarkiewicz Oct 1, 2025

Let's bring this back to original schema name.

Suggested change

      
                quickbooks_schema: quickbooks_integration_tests_22
          
                quickbooks_schema: quickbooks_integration_tests

integration_tests/ci/sample.profiles.yml Outdated

                     dbname: "{{ env_var('CI_REDSHIFT_DBT_DBNAME') }}"
                     port: 5439
-                    schema: quickbooks_integration_tests_21
+                    schema: quickbooks_integration_tests_22

Contributor

fivetran-joemarkiewicz Oct 1, 2025

Suggested change

      
                  schema: quickbooks_integration_tests_22
          
                  schema: quickbooks_integration_tests

integration_tests/ci/sample.profiles.yml Outdated

                     method: service-account-json
                     project: 'dbt-package-testing'
-                    schema: quickbooks_integration_tests_21
+                    schema: quickbooks_integration_tests_22

Contributor

fivetran-joemarkiewicz Oct 1, 2025

Suggested change

      
                  schema: quickbooks_integration_tests_22
          
                  schema: quickbooks_integration_tests

integration_tests/ci/sample.profiles.yml Outdated

                     database: "{{ env_var('CI_SNOWFLAKE_DBT_DATABASE') }}"
                     warehouse: "{{ env_var('CI_SNOWFLAKE_DBT_WAREHOUSE') }}"
-                    schema: quickbooks_integration_tests_21
+                    schema: quickbooks_integration_tests_22

Contributor

fivetran-joemarkiewicz Oct 1, 2025

Suggested change

      
                  schema: quickbooks_integration_tests_22
          
                  schema: quickbooks_integration_tests

integration_tests/ci/sample.profiles.yml Outdated

                     dbname: "{{ env_var('CI_POSTGRES_DBT_DBNAME') }}"
                     port: 5432
-                    schema: quickbooks_integration_tests_21
+                    schema: quickbooks_integration_tests_22

Contributor

fivetran-joemarkiewicz Oct 1, 2025

Suggested change

      
                  schema: quickbooks_integration_tests_22
          
                  schema: quickbooks_integration_tests

integration_tests/ci/sample.profiles.yml Outdated

                     host: "{{ env_var('CI_DATABRICKS_DBT_HOST') }}"
                     http_path: "{{ env_var('CI_DATABRICKS_DBT_HTTP_PATH') }}"
-                    schema: quickbooks_integration_tests_21
+                    schema: quickbooks_integration_tests_22

Contributor

fivetran-joemarkiewicz Oct 1, 2025

Suggested change

      
                  schema: quickbooks_integration_tests_22
          
                  schema: quickbooks_integration_tests


          schema updates

78284ad

fivetran-catfritz approved these changes

View reviewed changes

Contributor

fivetran-catfritz left a comment

lgtm!

fivetran-avinash merged commit f9c08cb into main

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready next-release