Upgrade CodeMirror to 5.48.2 #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joergschiller
changed the title
Author
|
@fixlr just bumped it to 5.48.2 |
Using 1.4 doesn't work:
Specified 'sqlite3' for database adapter, but the gem is not loaded. Add `gem 'sqlite3'` to your Gemfile (and ensure its version is at the minimum required by ActiveRecord). (Gem::LoadError)
Include newer ruby version/remove very old ones and relax version requirements. Kept 1.9 for now as it was handled separately before.
Travis CI/RVM has no binaries.
Rails 4.2.8 is the first version which support Ruby 2.4.
bundler version incompatible
Author
|
@fixlr I also changed the matrix of Travis CI builds to let them work with the published Ruby binaries (also added a dummy Rails 4.2). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Is there anything more I can provide you with to consider merging this PR?
Kind regards,
Jörg