Repository navigation
Conversation
Member
|
Merged as 51e80c5. The final diff only changes Inductor can serialize All four offline Inductor/Triton compilation checks pass and preserve the baseline PTX instructions. Static checks pass. GPU runtime validation and timings remain pending. |
yzhangcs
marked this pull request as draft
October 10, 2026 07:43
yzhangcs
marked this pull request as ready for review
October 10, 2026 07:47
yzhangcs
previously approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix unresolved
softplusandsoftplus2references in Inductor-generated Triton kernels. Replace platform-selected function aliases with named JIT forwarding functions so generated callers and helper definitions use matching names. The existing implementations, arithmetic, and platform selection are preserved. See also pytorch/pytorch#198050.The final diff only changes
fla/ops/utils/softplus.py.Test plan
git diff --check.Benchmark / NCU
Offline PTX instruction comparisons match the baseline for all four helper/implementation combinations, excluding debug information. GPU latency measurements are pending; NCU was not run.
Breaking changes
None. Public signatures, numerical algorithms, and backend selection are unchanged.
Checklist