Repository navigation
[Fix] Honor 1D strides in Ascend activations and follow module aliases in test selection - #1374
Merged
Merged
Conversation
…s in test selection
4 of 6 tasks
Contributor
Author
|
@zhiyuan1i @zheliuyu This pr is ready for review. Could you please review this PR? Thanks! |
Collaborator
|
LGTM. |
zhiyuan1i
approved these changes
Oct 12, 2026
4 of 5 tasks
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_is_inner_contiguousin Ascend vector activation, all 1D tensors were previously treated as internally contiguous. Views likex[::3]havestride(-1) != 1, while the kernel uses dense column-wise indexing. Therefore, for 1D tensors, we now checkis_contiguous()and callcontiguous()when non-contiguous.find_dependent_testsalso reads_MODULE_ALIASES. Imports for single-target aliases (e.g.,fla.modules.l2norm→fla.modules.norm.l2norm) are mapped to canonical modules and expanded alongside re-exports; multi-target aliases (e.g.,conv) are not expanded.Test plan
FLA_NPU_XDIST=1 ASCEND_RT_VISIBLE_DEVICES=0,1,2,3,4,5,6,7 pytest -s -v --exitfirst -n 8 --dist load tests/modules/ tests/test_dependency_finder.py

Benchmark / NCU
Not involved
Breaking changes
None
Checklist
Large PR justification
If you ticked the "minor" box above