[KernelGen][Nvidia] Add _cholesky_solve_helper operator with Triton kernel - #5081
Open
Yukun-Cui wants to merge 3 commits into
Open
[KernelGen][Nvidia] Add _cholesky_solve_helper operator with Triton kernel#5081Yukun-Cui wants to merge 3 commits into
Yukun-Cui wants to merge 3 commits into
Conversation
Yukun-Cui
requested review from
0x45f,
103yiran,
Caeruleann,
bin913,
douxetpur,
hellojack163,
huangyiqun,
tengqm and
w1120029931-bit
as code owners
July 30, 2026 10:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Operator
Type of Change
New Feature
Description
Adds a two-stage Triton triangular solve for
_cholesky_solve_helper, including broadcasted batch handling and upper/lower factor support.This is a reviewed and updated reintroduction of the implementation previously discussed in #3354.
Issue
Related prior PR: #3354
Progress
Testing
pytest -q tests/test_cholesky_solve_helper.py— PASS (6 cases) on NVIDIA H20Performance
Command:
pytest -q benchmark/test_cholesky_solve_helper.py --level core -son NVIDIA H20.Core suite: 5 cases, geometric mean speedup 0.217x, measured range 0.200x–0.229x.
This initial implementation prioritizes correctness and operator coverage.
Multi-backend Testing
Files Changed