Modify ELU backward implementation to match Torch - #927
Merged
Conversation
Blury233
changed the title
StrongSpoon
self-requested a review
September 1, 2025 03:28
StrongSpoon
reviewed
Sep 1, 2025
| # res_grad_out, alpha, scale, input_scale, False, res_inp | ||
| # ) | ||
|
|
||
| # gems_assert_close(res_in_grad, ref_in_grad, dtype) |
Collaborator
There was a problem hiding this comment.
please delete these code
| grad_input = tl.where( | ||
| y > 0, | ||
| grad_output * scale * input_scale, | ||
| grad_output * (y * input_scale + scale * alpha * input_scale), |
Collaborator
There was a problem hiding this comment.
what about grad_output * (y + scale * alpha) * input_scale?
meinie0826
pushed a commit
that referenced
this pull request
Sep 15, 2025
* Align with torch * ELU-backward-modification * fix issue
nicelynice
pushed a commit
to nicelynice/FlagGems
that referenced
this pull request
Feb 24, 2026
* Align with torch * ELU-backward-modification * fix issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Operator
Type of Change
Bug Fix
Description
Align ELU backward input with Torch implementation
Issue
Progress
Performance
ELU backward Accuracy Test
ELU backward Performance Test