find_package(lz4 CONFIG)#507
Closed
felixf4xu wants to merge 1 commit into
Closed
Conversation
kangzixiang
approved these changes
Dec 12, 2023
|
Is there any reason why this has not been merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR is another try to fix #435, #417, and #403
Different from #400 , this PR tries to find_package
lz4first, if found, include and linklz4, otherwise it falls back toPkgConfig. This is a more cmake friendly change, in my point of view.This PR is based on the fact that, if lz4 is built and installed from source using cmake, it already has support of cmake, see code https://github.com/lz4/lz4/tree/dev/build/cmake. This PR does not add too much additional cmake script but use upstream of
lz4's cmake support.