Dependabot/npm and yarn/frontend/storybook 8.5.x #947

ervcz · 2025-02-21T09:46:18Z

Update Storybook Version to 8.5.x

Refactor story definitions according to the migration guides
Add new test-runner for storybook as storybook tests (storyshots) have been removed
Generate the new snapshots and remove old ones snapshots
Parametrize animated charts to be able to turn their animations off
New entry in Makefile to integrate the new test runner for storybook
Update CI runners' base image from 22.04 to 24.04

How to use

Submit new PRs and watch the frontend CI pipeline execution (make ci step).

Testing done

Locally by running CI=true make ci and inspecting the output
Letting the GitHub actions to execute the frontend workflow multiple times

Copilot

Copilot reviewed 66 out of 66 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/frontend.yml:32

Using 'continue-on-error: true' might hide failures in the CI process; if this behavior is intentional, consider adding a comment or documentation to explain why it is safe to ignore errors.

continue-on-error: true

frontend/.storybook/test-runner.ts

Copilot

Copilot reviewed 69 out of 69 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

frontend/.storybook/test-runner.ts:24

Consider providing a more descriptive error message that includes additional context (such as which story or page state triggered the error) to aid debugging when '#storybook-root' is not found.

throw new Error("elementHandler is null!");

frontend/.storybook/manager.js:1

Please verify that replacing the import from '@storybook/addons' with '@storybook/manager-api' aligns with your current Storybook version requirements and that it does not break integrations relying on the legacy API.

import { addons } from '@storybook/manager-api';

frontend/.storybook/main.js:1

[nitpick] The legacy '.storybook/main.js' configuration file has been entirely removed. Please confirm that all references to this configuration have been updated to use the new 'main.ts' setup to avoid unexpected issues.

module.exports = { ... }

tormath1 · 2025-02-25T14:29:19Z

I think those two commits:

Can be squashed? IIUC you just want to add back the docker compose version right?

ervcz · 2025-02-25T14:43:46Z

I think those two commits:

e80aed7

30572e9

Can be squashed? IIUC you just want to add back the docker compose version right?

Yes. I wanted to see if the CI runner image gets the old docker-compose or newer docker compose as it was giving errors sometimes that the command couldn't be found. Upgrading the runner from ubuntu 22.04 to 24.04 solved the issue in the end and the docker compose command is consistently available now.

tormath1

LGTM. It does not impact directly Nebraska itself except maybe for the typescript update. Speaking of which before merging can we squash the last two commits: 3c3b54c and 5ef77d4

ervcz · 2025-02-27T09:21:14Z

LGTM. It does not impact directly Nebraska itself except maybe for the typescript update. Speaking of which before merging can we squash the last two commits: 3c3b54c and 5ef77d4

Will do so :)

Bumps [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli) from 7.6.20 to 8.5.6. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.5.6/code/lib/cli) --- updated-dependencies: - dependency-name: storybook dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>

- Refactor story definitions according to the migration guides - Add new test-runner for storybook as storybook tests (storyshots) have been removed - Generate the new snapshots

…ed charts - generate new snapshots - parametrize animated charts - new entry in Makefile to integrate the new test runner for storybook

…flow - Added Playwright test execution to the frontend CI workflow. - Removed the separate Playwright workflow file. - Updated the Makefile to include Playwright installation and test commands. - Modified `.gitignore` to include `playwright-failed`. - Updated `package.json` and `package-lock.json` with new dependencies for Storybook testing. - Added a page reload step in the Playwright test to ensure content is loaded.

- Bumped Storybook-related dependencies to version `8.5.8` in `package.json` and `package-lock.json`. - Updated `@storybook/test-runner` to version `0.21.3`. - Update makefile

…ement & update ts - Updated TypeScript version from `^4.4.x` to `^5.7.3` in `package.json` and `package-lock.json`. - Removed unused import of `React` in `Common.tsx` and `SectionHeader.tsx`. - Fixed type coercion issue in `InstanceCountLabel` component by converting `countText` to a number. - Ensured `aria-label` in `SectionHeader` uses `toString()` for translation. - facebook/create-react-app#13080 - certain deps demand higher ts version while react-scripts still depend on older ts versions - react-scripts still works fine with newer ts therefore overwrite ts version

- Added tests for `setToken`, `getToken`, and `isValidToken` functions in `auth.spec.ts`. - Added tests for `getKeyByValue`, `cleanSemverVersion`, `getInstanceStatus`, and `getErrorAndFlags` functions in `helpers.spec.ts`.

…napshots

* refactor(frontend:storybook): upgrade from storybook 7 to 8 - Refactor story definitions according to the migration guides - Add new test-runner for storybook as storybook tests (storyshots) have been removed - Generate the new snapshots * refactor(frontend): remove storyshots as the package got deprecated * refactor(frontend:storybook): generate new snaps & parametrize animated charts - generate new snapshots - parametrize animated charts - new entry in Makefile to integrate the new test runner for storybook * feat(ci): integrate storybook and Playwright tests into frontend workflow - Added Playwright test execution to the frontend CI workflow. - Removed the separate Playwright workflow file. - Updated the Makefile to include Playwright installation and test commands. - Modified `.gitignore` to include `playwright-failed`. - Updated `package.json` and `package-lock.json` with new dependencies for Storybook testing. - Added a page reload step in the Playwright test to ensure content is loaded. * chore(frontend): minor storybook version update & ci changes - Bumped Storybook-related dependencies to version `8.5.8` in `package.json` and `package-lock.json`. - Updated `@storybook/test-runner` to version `0.21.3`. - Update makefile * fix(frontend): improve error message for missing '#storybook-root' element & update ts - Updated TypeScript version from `^4.4.x` to `^5.7.3` in `package.json` and `package-lock.json`. - Removed unused import of `React` in `Common.tsx` and `SectionHeader.tsx`. - Fixed type coercion issue in `InstanceCountLabel` component by converting `countText` to a number. - Ensured `aria-label` in `SectionHeader` uses `toString()` for translation. - facebook/create-react-app#13080 - certain deps demand higher ts version while react-scripts still depend on older ts versions - react-scripts still works fine with newer ts therefore overwrite ts version - Added tests for `setToken`, `getToken`, and `isValidToken` functions in `auth.spec.ts`. - Added tests for `getKeyByValue`, `cleanSemverVersion`, `getInstanceStatus`, and `getErrorAndFlags` functions in `helpers.spec.ts`.

ervcz mentioned this pull request Feb 21, 2025

build(deps-dev): bump storybook from 7.6.20 to 8.5.8 in /frontend #945

Closed

ervcz requested a review from Copilot February 21, 2025 09:53

Copilot AI reviewed Feb 21, 2025

View reviewed changes

frontend/.storybook/test-runner.ts Outdated Show resolved Hide resolved

github-actions bot mentioned this pull request Feb 22, 2025

Monthly contributions report 2025-01-22 - 2025-02-21 flatcar/Flatcar#1658

Closed

ervcz force-pushed the dependabot/npm_and_yarn/frontend/storybook-8.5.6 branch from a2d9bc4 to 7f0b56d Compare February 25, 2025 11:18

ervcz changed the title ~~Dependabot/npm and yarn/frontend/storybook 8.5.6~~ Dependabot/npm and yarn/frontend/storybook 8.5.x Feb 25, 2025

ervcz requested a review from Copilot February 25, 2025 11:40

Copilot AI reviewed Feb 25, 2025

View reviewed changes

ervcz marked this pull request as ready for review February 25, 2025 11:56

ervcz requested review from a team February 25, 2025 14:22

ervcz force-pushed the dependabot/npm_and_yarn/frontend/storybook-8.5.6 branch from fb7e9f5 to a4c18eb Compare February 25, 2025 14:39

ervcz mentioned this pull request Feb 25, 2025

build(deps-dev): bump @storybook/addon-links from 7.6.20 to 8.5.8 in /frontend #946

Closed

ervcz force-pushed the dependabot/npm_and_yarn/frontend/storybook-8.5.6 branch from a4c18eb to acac634 Compare February 26, 2025 08:50

tormath1 reviewed Feb 27, 2025

View reviewed changes

dependabot bot and others added 8 commits March 7, 2025 15:06

refactor(frontend:storybook): upgrade from storybook 7 to 8

abdc102

- Refactor story definitions according to the migration guides - Add new test-runner for storybook as storybook tests (storyshots) have been removed - Generate the new snapshots

chore(frontend): fix styling issues

a7c27b3

refactor(frontend): remove storyshots as the package got deprecated

0c079d8

refactor(frontend:storybook): generate new snaps & parametrize animat…

35f769c

…ed charts - generate new snapshots - parametrize animated charts - new entry in Makefile to integrate the new test runner for storybook

chore(frontend): minor storybook version update & ci changes

6bcc786

- Bumped Storybook-related dependencies to version `8.5.8` in `package.json` and `package-lock.json`. - Updated `@storybook/test-runner` to version `0.21.3`. - Update makefile

ervcz force-pushed the dependabot/npm_and_yarn/frontend/storybook-8.5.6 branch from 3c3b54c to 8d6cbda Compare March 7, 2025 13:08

ervcz added 2 commits March 7, 2025 15:33

test(frontend): add unit tests for auth and helper utilities

d0b7916

- Added tests for `setToken`, `getToken`, and `isValidToken` functions in `auth.spec.ts`. - Added tests for `getKeyByValue`, `cleanSemverVersion`, `getInstanceStatus`, and `getErrorAndFlags` functions in `helpers.spec.ts`.

chore(frontend:test): add aria-label to loading indicators in story s…

1fbeba3

…napshots

ervcz merged commit 2f4ad9f into main Mar 7, 2025
3 checks passed

ervcz deleted the dependabot/npm_and_yarn/frontend/storybook-8.5.6 branch March 7, 2025 14:36

github-actions bot mentioned this pull request Mar 22, 2025

Monthly contributions report 2025-02-22 - 2025-03-21 flatcar/Flatcar#1694

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dependabot/npm and yarn/frontend/storybook 8.5.x #947

Dependabot/npm and yarn/frontend/storybook 8.5.x #947

Uh oh!

ervcz commented Feb 21, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

tormath1 commented Feb 25, 2025

Uh oh!

ervcz commented Feb 25, 2025 •

edited

Loading

Uh oh!

tormath1 left a comment

Uh oh!

ervcz commented Feb 27, 2025

Uh oh!

Uh oh!

Uh oh!

Dependabot/npm and yarn/frontend/storybook 8.5.x #947

Dependabot/npm and yarn/frontend/storybook 8.5.x #947

Uh oh!

Conversation

ervcz commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Update Storybook Version to 8.5.x

How to use

Testing done

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

tormath1 commented Feb 25, 2025

Uh oh!

ervcz commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tormath1 left a comment

Choose a reason for hiding this comment

Uh oh!

ervcz commented Feb 27, 2025

Uh oh!

Uh oh!

Uh oh!

ervcz commented Feb 21, 2025 •

edited

Loading

ervcz commented Feb 25, 2025 •

edited

Loading