changed mach reynolds to use charcteristic length#1138
Merged
benflexcompute merged 4 commits intodevelopfrom Jun 11, 2025
Merged
changed mach reynolds to use charcteristic length#1138benflexcompute merged 4 commits intodevelopfrom
benflexcompute merged 4 commits intodevelopfrom
Conversation
flow360/component/simulation/operating_condition/operating_condition.py
Outdated
Show resolved
Hide resolved
…dition.py Co-authored-by: Maciej Skarysz <83596707+maciej-flexcompute@users.noreply.github.com>
benflexcompute
approved these changes
Jun 11, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
* changed mach reynolds to use charcteristic length * Update flow360/component/simulation/operating_condition/operating_condition.py Co-authored-by: Maciej Skarysz <83596707+maciej-flexcompute@users.noreply.github.com> * reynolds->reynolds_mesh_unit and reverted back to project_length_unit * Update notebook_tutorial_2D_crm.ipynb --------- Co-authored-by: Maciej Skarysz <83596707+maciej-flexcompute@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
* changed mach reynolds to use charcteristic length * Update flow360/component/simulation/operating_condition/operating_condition.py Co-authored-by: Maciej Skarysz <83596707+maciej-flexcompute@users.noreply.github.com> * reynolds->reynolds_mesh_unit and reverted back to project_length_unit * Update notebook_tutorial_2D_crm.ipynb --------- Co-authored-by: Maciej Skarysz <83596707+maciej-flexcompute@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think characteristic_length is a better name than reference_length since it won't get confused with the one for moments and is also more common definition used in defining Reynolds number globally I believe.
For reference, here is a Wikipedia page where it is also called characteristic length.
