Skip to content

Fix Deserialize function when handling None description #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angranl-flex merged 3 commits into from
Jul 24, 2025
Merged

Fix Deserialize function when handling None description #1286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d780d17
Update to_file implementatino to exclude None when dumpping json
angranl-flex Jul 24, 2025
1efd7fd
Make sure deserialize can handle None description situation
angranl-flex Jul 24, 2025
9adb3dd
Add fixed to_yaml
angranl-flex Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flow360/component/simulation/framework/base_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ def _to_json(self, filename: str, **kwargs) -> None:
-------
>>> params._to_json(filename='folder/flow360.json') # doctest: +SKIP
"""
json_string = self.model_dump_json(**kwargs)
json_string = self.model_dump_json(exclude_none=True, **kwargs)
model_dict = json.loads(json_string)
if self.model_config["include_hash"] is True:
model_dict["hash"] = self._calculate_hash(model_dict)
Expand Down Expand Up @@ -522,7 +522,7 @@ def _to_yaml(self, filename: str, **kwargs) -> None:
-------
>>> params._to_yaml(filename='folder/flow360.yaml') # doctest: +SKIP
"""
json_string = self.model_dump_json(**kwargs)
json_string = self.model_dump_json(exclude_none=True, **kwargs)
model_dict = json.loads(json_string)
if self.model_config["include_hash"]:
model_dict["hash"] = self._calculate_hash(model_dict)
Expand Down
5 changes: 3 additions & 2 deletions flow360/component/simulation/user_code/core/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,12 +362,13 @@ def deserialize(cls, values):
new_value,
)

if "description" in values:
if "description" in values and values["description"] is not None:
if not isinstance(values["description"], str):
raise ValueError(
f"Description must be a string but got {type(values['description'])}."
)
default_context.set_metadata(values["name"], "description", values.pop("description"))
default_context.set_metadata(values["name"], "description", values["description"])
values.pop("description", None)

return values

Expand Down
Loading