Skip to content

Remove dumping stop criterion data to Flow360. json #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angranl-flex merged 1 commit into from
Oct 20, 2025
Merged

Remove dumping stop criterion data to Flow360. json #1513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions flow360/component/simulation/translator/solver_translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1637,10 +1637,6 @@ def get_solver_json(
}
)
translated["runControl"]["shouldCheckStopCriterion"] = bool(model.stopping_criterion)
if model.stopping_criterion:
translated["runControl"]["stopCriterion"] = [
dump_dict(criterion) for criterion in model.stopping_criterion
]

translated["initialCondition"] = get_navier_stokes_initial_condition(
model.initial_condition
Expand Down
23 changes: 4 additions & 19 deletions tests/simulation/translator/ref/Flow360_om6wing_stopping_criterion_and_moving_statistic.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,13 @@
"animationFrequency": 1,
"animationFrequencyOffset": 0,
"computeTimeAverages": false,
"monitorLocations" : {"Point1" : [
"monitorLocations": {
"Point1": [
-0.033058692145427476,
0.7024941059684825,
0.0
]
},
},
"outputFields": [
"Helicity"
],
Expand Down Expand Up @@ -84,22 +85,6 @@
"runControl": {
"shouldCheckStopCriterion": true,
"externalProcessMonitorOutput": true,
"stopCriterion": [
{
"monitorField": {
"name": "Helicity",
"typeName": "UserVariable"
},
"monitorOutput": "11111",
"name": "Criterion_Helicity",
"tolerance": {
"typeName": "number",
"units": "m/s**2",
"value": 18.66
},
"typeName": "StopCriterion"
}
],
"monitorProcessorHash": "8ef791f02ebfdac5738ea98d3328b6530b3188e3600f0fd80197247115576a9b"
},
"sliceOutput": {
Expand Down Expand Up @@ -231,4 +216,4 @@
"outputFormat": "paraview",
"startAverageIntegrationStep": -1
}
}
}
Loading