Add sliding_interface_tolerance and stationary_enclosed_entity parameters#1625
Merged
shreyas-flex merged 7 commits intomainfrom Dec 10, 2025
Merged
Conversation
Contributor
shreyas-flex
commented
Dec 1, 2025
shreyas-flex
commented
- Adds two important parameters related to sliding interface intersecting wall feature:
- sliding_interface_tolerance : used to decide whether a point/curve lies on the sliding interface.
- stationary_enclosed_entities : used to denote to solver that certain bodies within sliding interface are not rotating with respect to frame of reference of overall simulation
…d-to-sliding-interface-fusion rebasing
…d-to-sliding-interface-fusion rebase
Collaborator
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
flow360/component/simulation/translator/volume_meshing_translator.py
Outdated
Show resolved
Hide resolved
flow360/component/simulation/translator/volume_meshing_translator.py
Outdated
Show resolved
Hide resolved
flow360/component/simulation/translator/surface_meshing_translator.py
Outdated
Show resolved
Hide resolved
benflexcompute
approved these changes
Dec 10, 2025
shreyas-flex
deleted the
shreyas/params-related-to-sliding-interface-fusion
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.