Make gap_treatment_strength optional with a default value of None#1656
Merged
savithru-flex merged 2 commits intomainfrom Dec 15, 2025
Merged
Make gap_treatment_strength optional with a default value of None#1656savithru-flex merged 2 commits intomainfrom
savithru-flex merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the gap_treatment_strength parameter to be optional with a default value of None instead of 0, removing it from JSON output when not explicitly set.
- Changed default value from
0toNonein bothMeshingParamsandVolumeMeshingParamsclasses - Added conditional check to only include
gapTreatmentStrengthin output JSON when the value is notNone - Updated test files and reference JSON files to remove the default
gapTreatmentStrength: 0.0entries
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| flow360/component/simulation/meshing_param/params.py | Changed default value of gap_treatment_strength from 0 to None in both parameter classes |
| flow360/component/simulation/translator/volume_meshing_translator.py | Added conditional check to only include gapTreatmentStrength in output when not None |
| tests/simulation/translator/test_volume_meshing_translator.py | Removed gapTreatmentStrength: 0.0 from test assertions |
| tests/simulation/translator/ref/volume_meshing/*.json | Removed gapTreatmentStrength: 0.0 from reference JSON files |
| tests/ref/simulation/*.json | Removed gap_treatment_strength: 0.0 from reference JSON files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
flow360/component/simulation/translator/volume_meshing_translator.py
Outdated
Show resolved
Hide resolved
…nt strength. Added planar face tolerance to GAI whitelist.
benflexcompute
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.