Skip to content

Make gap_treatment_strength optional with a default value of None#1656

Merged
savithru-flex merged 2 commits intomainfrom
savithru/optionalGapTreatmentStrength
Dec 15, 2025
Merged

Make gap_treatment_strength optional with a default value of None#1656
savithru-flex merged 2 commits intomainfrom
savithru/optionalGapTreatmentStrength

Conversation

@savithru-flex
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the gap_treatment_strength parameter to be optional with a default value of None instead of 0, removing it from JSON output when not explicitly set.

  • Changed default value from 0 to None in both MeshingParams and VolumeMeshingParams classes
  • Added conditional check to only include gapTreatmentStrength in output JSON when the value is not None
  • Updated test files and reference JSON files to remove the default gapTreatmentStrength: 0.0 entries

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
flow360/component/simulation/meshing_param/params.py Changed default value of gap_treatment_strength from 0 to None in both parameter classes
flow360/component/simulation/translator/volume_meshing_translator.py Added conditional check to only include gapTreatmentStrength in output when not None
tests/simulation/translator/test_volume_meshing_translator.py Removed gapTreatmentStrength: 0.0 from test assertions
tests/simulation/translator/ref/volume_meshing/*.json Removed gapTreatmentStrength: 0.0 from reference JSON files
tests/ref/simulation/*.json Removed gap_treatment_strength: 0.0 from reference JSON files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@savithru-flex savithru-flex enabled auto-merge (squash) December 15, 2025 20:59
…nt strength. Added planar face tolerance to GAI whitelist.
@savithru-flex savithru-flex merged commit 2446622 into main Dec 15, 2025
20 checks passed
@savithru-flex savithru-flex deleted the savithru/optionalGapTreatmentStrength branch December 15, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants