[Hotfix 25.7]: fix(): Added a check to skip validation for legacy cloud assets without bounding box information in the simulation parameters validation function.#1711
Merged
benflexcompute merged 2 commits intorelease-candidate/25.7from Jan 9, 2026
Conversation
…ut bounding box information in the simulation parameters validation function. (#1709)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87c667eb82
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
benflexcompute
approved these changes
Jan 9, 2026
github-actions bot
added a commit
that referenced
this pull request
Jan 9, 2026
…ud assets without bounding box information in the simulation parameters validation function. (#1711) Co-authored-by: Ben <[email protected]> Co-authored-by: benflexcompute <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix of PR #1709 (#1709) to the
release-candidate/25.7branch.Hey @benflexcompute, please review this hotfix PR created from your original PR.
Note
Hotfix to avoid false validation errors with legacy cloud assets missing bounding boxes.
validation_simulation_params._check_complete_boundary_condition_and_unknown_surface, early-return whenfarfield_methodis set and anyasset_boundary_entitiesitem hasprivate_attributes is None.private_attributes.bounding_boxto surfaces intests/simulation/params/data/surface_mesh/simulation.jsonand various unit tests; constructSurfacewithSurfacePrivateAttributesin fixtures and mocks to satisfy new check.Written by Cursor Bugbot for commit 87c667e. This will update automatically on new commits. Configure here.