Skip to content

[Hotfix Main]: [FXC-5244] fix(): Added validator for write_single_file to surface output#1766

Merged
piotrkluba merged 5 commits intomainfrom
hotfix-main-pr1756
Feb 4, 2026
Merged

[Hotfix Main]: [FXC-5244] fix(): Added validator for write_single_file to surface output#1766
piotrkluba merged 5 commits intomainfrom
hotfix-main-pr1756

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 4, 2026

Hotfix of PR #1756 (#1756) to the main branch.
Hey @piotrkluba, please review this hotfix PR created from your original PR.

⚠️ Note: This PR had conflicts with the base branch and was resolved automatically. Please review the changes carefully.


Note

Low Risk
Small, localized validation change that only affects parameter construction/validation for surface outputs; primary risk is stricter validation breaking previously-accepted (but unsupported) configs.

Overview
Adds a SurfaceOutput model-level validator that enforces write_single_file can only be used with Tecplot output: it now errors for output_format="paraview" and emits a validation warning for output_format="both" (Tecplot single file + separate Paraview files).

Updates/extends tests to cover the new validator behavior and adjusts existing fixtures/usages to explicitly set output_format="tecplot" where write_single_file=True to keep tests valid.

Written by Cursor Bugbot for commit bfbf098. This will update automatically on new commits. Configure here.

@piotrkluba piotrkluba marked this pull request as ready for review February 4, 2026 15:26
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@piotrkluba piotrkluba enabled auto-merge (squash) February 4, 2026 15:38
@piotrkluba piotrkluba merged commit 21b9dff into main Feb 4, 2026
21 checks passed
@piotrkluba piotrkluba deleted the hotfix-main-pr1756 branch February 4, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant