[Hotfix Main]: [FXC-5244] fix(): Added validator for write_single_file to surface output#1766
Merged
piotrkluba merged 5 commits intomainfrom Feb 4, 2026
Merged
[Hotfix Main]: [FXC-5244] fix(): Added validator for write_single_file to surface output#1766piotrkluba merged 5 commits intomainfrom
piotrkluba merged 5 commits intomainfrom
Conversation
piotrkluba
approved these changes
Feb 4, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix of PR #1756 (#1756) to the
mainbranch.Hey @piotrkluba, please review this hotfix PR created from your original PR.
Note
Low Risk
Small, localized validation change that only affects parameter construction/validation for surface outputs; primary risk is stricter validation breaking previously-accepted (but unsupported) configs.
Overview
Adds a
SurfaceOutputmodel-level validator that enforceswrite_single_filecan only be used with Tecplot output: it now errors foroutput_format="paraview"and emits a validation warning foroutput_format="both"(Tecplot single file + separate Paraview files).Updates/extends tests to cover the new validator behavior and adjusts existing fixtures/usages to explicitly set
output_format="tecplot"wherewrite_single_file=Trueto keep tests valid.Written by Cursor Bugbot for commit bfbf098. This will update automatically on new commits. Configure here.