Python client changes for transient MRF feature. isMRF flag is added.#580
Merged
NasserFlexCompute merged 10 commits intodevelopfrom Dec 11, 2024
Merged
Python client changes for transient MRF feature. isMRF flag is added.#580NasserFlexCompute merged 10 commits intodevelopfrom
NasserFlexCompute merged 10 commits intodevelopfrom
Conversation
anshulmittal-flex
requested review from
NasserFlexCompute and
benflexcompute
Collaborator
There was a problem hiding this comment.
Looking good. Can you fix the linter and formatting?
what I usually do is having these in my bashrc:
alias formatPy="/disk2/ben/testcases/src/Flow360Core/Flow360/.venv/bin/black ./ --exclude '/\.venv/' && /disk2/ben/testcases/src/Flow360Core/Flow360/.venv/bin/isort . --skip .venv"
alias checkLint='/disk2/ben/testcases/src/Flow360Core/Flow360/.venv/bin/pylint $(git ls-files "flow360/*.py") --rcfile .pylintrc'
and replace "/disk2/ben/testcases/src/Flow360Core/Flow360/.venv/bin" with your own ones.
Contributor
NasserFlexCompute
left a comment
NasserFlexCompute
left a comment
There was a problem hiding this comment.
Let's avoid using abbreviations in the interface. How about calling the user entry "moving_reference_frame"? It'll be a lot easier for user to remember compared to isMRF.
benflexcompute
approved these changes
Nov 21, 2024
zones. Added validation checks and modified the exisiting unit tests.
noninertial_reference_frame_model.
NasserFlexCompute
force-pushed
the
anshul/Transient_MRF_001
branch
from
ce43353 to
2db7830
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.