[SCFD-4264] fix(): Add validation to prevent steady simulation with aeroacoustics#713
Merged
benflexcompute merged 2 commits intorelease-candidate/25.2from Feb 4, 2025
Merged
Conversation
benflexcompute
added
the
Hotfix-pending
benflexcompute
changed the title
angranl-flex
approved these changes
Feb 4, 2025
benflexcompute
added a commit
that referenced
this pull request
Feb 4, 2025
…eroacoustics (#713) * fix(): Add validation to prevent steady simulation with aeroacoustics * Removed time_stepping check of None
angranl-flex
added a commit
that referenced
this pull request
Apr 1, 2025
* Bump default solver version to 25.2 * fix(): Removed auto error message about mesh file format. And bump default solver version to 25.0 (#692) (#693) * fix(): Removed auto error message about mesh file format. And bump default solver version to 25.0 * Fixed unit test * Bump Python client version in toml file * fix(): Updater not updating the JSON and also a None input was not treated (#694) (#695) * fix(): Updater not updating the JSON and also a None input was not treated * Added info log about initial SimulationParam * Add rotation_correction support for SST (#700) (#701) * Add rotation_correction support for SST * Remove extra space * Add updater for beta version and remove treat_as_file_content/use_updater option (#699) (#702) * add support for beta version in the updater. * Remove treat_as_file_content and use_updater * add unit test for b\d+ version * Address comments * Remove storing beta version but support loading a beta version. * fix unit test * [SCFD-4036] fix(): Add validation that output fields should match turb model used (#703) * fix(): Add validation that output fields should match turb model used * Comments addressed * removed unnecessary * feat(): Added function to compute Reynolds number (#706) (#709) * Added function to compute reynolds number * Removed prints * Renamed for less confusion * Update flow360/component/simulation/operating_condition/operating_condition.py --------- Co-authored-by: yifan-flex <124317394+yifan-flex@users.noreply.github.com> * Fix updater when checking draft_entities (#707) (#710) * Fix updater when checking draft_entities * Add unit test for deserialization with updater * Address comments * Fix ALL variable * [SCFD-3897] fix(): Use private_attribute_id to identify duplicate entity (#705) (#712) * Use private_attribute_id to identify duplicate entity * Use private_id for draft entities and name for other entities * Address comments * Add unittest to confirm draft entities with the same name is not identified as duplicates. * change location and keys of X/Y_slicing_forceDistribution.csv (#683) (#711) * change location and keys of X/Y_slicing_forceDistribution.csv * fix testing on the x slicing * add _preprocess for X_slicing force distribution result model * update ref results of force distribution * lint * minor * Extend report generation feature for service tests (#676) (#714) * Add linearResidual * Add include option to Chart2D * Add option to Average operation to convert output to boolean type * Add table setting * Improve get_variables function in an expression * Fix data filter in the PerEntityResultCSVModel * Add docstring * Add cfl requirement map * Remove table settings and use select_indices instead * Add boolean formatter * Fix unit test * [SCFD-4264] fix(): Add validation to prevent steady simulation with aeroacoustics (#713) * fix(): Add validation to prevent steady simulation with aeroacoustics * Removed time_stepping check of None * [Hotfix] BET Translator and parse_model_dict for the BETDisk class (#717) * [FL-71] BET translator (#634) * wip translator adaptation * work in progress implementation of BET translator * code format * added xfoil support and converted to snake_case * black and isort * new ref files, content is retained, alias for xrotor, entitylist works * removed comments and fixed docstrings * file fixes * deleted unused import * code style fixes * file name change * added files for unittest * small fixes to bet unittest * fix to import in test_bet_translator * deleted sys.path from unittest * feat(): Flow360.json parser repack for BET translator (#698) * feat(): Flow360.json parser repack for BET translator * Comments addressed, added quant test * Fixed format and lint * Removed dependency on * Add data/ csv back * Move the test * Added test for multi constructor * Comments addressed, now fixing the docstring * Removed default of lenghunit to make it requrired * Also make angle_unit non-optional * Added docstring using out LLM * format * Abstracted out the open file operation from implementation --------- Co-authored-by: wiktor <wiktor.flexcompute.com> Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com> Co-authored-by: BenYuan <ben@flexcompute.com> * Fix parse_model_dict for the BETDisk class (#716) --------- Co-authored-by: wiktor-flex <wiktor.krzew@flexcompute.com> Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com> Co-authored-by: BenYuan <ben@flexcompute.com> * [SCFD4263] Add monitor conversion for V0 Flow360 json file (#719) (#723) * Add monitor conversion for V0 Flow360 json file * Fix length_unit to mesh_unit * Address comments * Removed comments stuff * [SCFD-3769] fix(): Python submited ghost surface not recognized by webUI (#725) * fix(): Python submited ghost surface not recognized by webUI Added unit test for updater Update tests/simulation/test_updater.py Co-authored-by: Angran <angran@flexcompute.com> Fix unit tests Added proper docstring * Fixed unit test * Update flow360/component/simulation/models/surface_models.py Co-authored-by: Angran <angran@flexcompute.com> * Update flow360/component/simulation/models/surface_models.py Co-authored-by: Angran <angran@flexcompute.com> * Update flow360/component/simulation/models/surface_models.py Co-authored-by: Angran <angran@flexcompute.com> * Update flow360/component/simulation/models/surface_models.py Co-authored-by: Angran <angran@flexcompute.com> * Fix docstring --------- Co-authored-by: Angran <angran@flexcompute.com> * configure shutter execution in parallel or serial (#727) (#729) * Revert "[SCFD-3769] fix(): Python submited ghost surface not recognized by we…" (#731) This reverts commit 7d849d8. * moved Slater from an Outflow to a wall BC (#720) (#737) * moved Slater from an Outflow to a wall BC * added initial_step to SlaterPorousBleed * modified initial_step for Slater BC * Applied Ben's PR comments * added validator for velocity and wall_velocity_model at same time * Added validation for both Wall.velocity and Wall.wall_velocity_model * Moved wall velocity model under * Added deserialization test for wall --------- Co-authored-by: johnmoore4 <johnpmooreiv@gmail.com> Co-authored-by: John Moore <john@flexcompute.com> * fixed tutorials to work with latest develop (#733) (#742) * fixed tutorials to work with latest develop Co-authored-by: wiktor-flex <wiktor.krzew@flexcompute.com> * [Hotfix] removed sys.stdout to fix jupyter notebooks cherry pick from 4e0aa69 (#739) (#744) * removed sys.stdout from log.py * Revert "Revert "[SCFD-3769] fix(): Python submited ghost surface not recogniz…" (#732) This reverts commit 8f78b18. Fixed the optaional setting and also add symeetric back * changed omega dimensionalization for bet converter (#736) (#747) * time_unit -> freestream_temperature --------- Co-authored-by: wiktor-flex <wiktor.krzew@flexcompute.com> * Fix solver version (#754) * Add length unit property to project (#751) * added support for using bet_forces_radial_distribution_v2.csv as results attribute (#756) (#757) * added support for bet_forces_radial_distribution_v2.csv * unittest fix and added bet_forces_radial_distribution to download() * add capability to sequentially process screenshots (#758) (#759) * add sequential_screenshot_generator * fix lint * [SCFD-4474] Add validation before draft submission (#761) (#762) * Add params validation before submitting the draft * Update validation func's name * Update error message print * Revert change in services * Implement validation function in project_utils and format the output message. * Fix black * Address comments * Imprevoed errpr message * fix(): SurfaceMeshEntityInfo had wrong boundaries implementation (#765) * fix(): SurfaceMeshEntityInfo had wrong boundaries implementation * IMprove the error message * Fix typo * [HOTFIX] add updater to 24.11.10 to 25.2 (#775) * [HOTFIX] add updater to 24.11.10 to 25.2 * Revert quick_start change * [SCFD-4346] Add interface to force create new resource (#745) (#777) * Initial interface implementation based on the API draft * Address comments * Remove duplicate run check * Fix black * Add unit test * Address comments * Fix typo * Prepare for 25.2.1b1 release * Water Interface support * ready to be reviewed * [FL-220]fix(): Added flag to indicate a may be deleted. (#771) * Add vorticity magnitude to common output fields (#767) (#784) * [SCFD-4498] Formatting error msg from backend (#785) (#787) * clean error msg * Formatting error msg from backend * Add raise_on_error option * fix pylint * Add optional to run_case, generate_mesh * revert adding optional to solver_version * allow ugrid+mapbc file as surface mesh (#786) (#792) * allow ugrid+mapbc file as surface mesh * lin * [SCFD-4271] Cleanup redundant keys in the json file in the constructor of SimulationParams (#730) (#790) * Remove _from_json and _from_yaml in the base_model * Divide clean_params_dict into two parts: - clean redundant keys from webUI json - clean unnecessary keys based on the validation level * Address comments * Address comments * [SCFD-4401] Add matrix type in unit_system to handle large point group in ProbeOutput (#734) (#794) * Matrix type implementation * added batch processing for unit conversions (#760) * fix unit test failure and warning * slightly optimize _batch_preprocess * optimize _remove_duplicate_entities to linear complexity * fix unit test again * Don't run _remove_duplicate_entities for Point * Revert change in unit_system.py * Fix unit conversion performance issues in model preprocessing for solver (#769) * Fixed unit test and also removed unneeded feature from entity_base * Removing prints --------- Co-authored-by: Angran <angran@flexcompute.com> Co-authored-by: Maciej Skarysz <83596707+maciej-flexcompute@users.noreply.github.com> Co-authored-by: Andrzej Krupka <156919532+andrzej-krupka@users.noreply.github.com> * [RC-25.2 HOTFIX] [SCFD-4402] Revert the from_file implementation of Project class and add new interfaces (#773) (#791) * [SCFD-4402] Revert the from_file implementation of Project class and add new interfaces (#773) * Draft implementation * Adapted the interface * Changed interface * Self reviewed * Renaming of the APIs --------- Co-authored-by: BenYuan <ben@flexcompute.com> * Delete examples/case_from_json.py * Delete examples/case_from_multiple_files/case_from_multiple_files.py * Delete examples/generate_multiple_meshes.py * Delete examples/template_script_load_mesh_run_case_or_sweep.py --------- Co-authored-by: Angran <angran@flexcompute.com> * Fix bug in VM from_file change (#797) * fix(): Redefine the surface issue enums (#795) * fix(): Redefine the surface issue enums * unit test added * Fix unit test * Bump version to 25.2.2b1 * Translator and the interface ready * added to __init__.py * Updated unit test to test the situation where "_id" is included in the params dict (#800) * Fix pylint * Added low mach prec, fixed density of water * fixed unit test and added conterxt and some validation for water simulation, need to add unit test for the validations * Fix lint * Add validation for wall and porous medium * Added missing validaiton unit tests * Freestream wrong validation * fix lint * Update the translator and add velocityScale to the json * Put all scale values under the outputScale key * Fix unit test * address comments * fix translator after merging and add unit test for translator * Revert changes in examples * Add alpha and beta to liquid op * Revert change in poetry.lock * Address comments 1st round * Add unit tests and fix format * Remove unused import --------- Co-authored-by: Angran <angran@flexcompute.com> Co-authored-by: yifan-flex <124317394+yifan-flex@users.noreply.github.com> Co-authored-by: Feilin <52168719+feilin-flexcompute@users.noreply.github.com> Co-authored-by: wiktor-flex <wiktor.krzew@flexcompute.com> Co-authored-by: johnmoore4 <johnpmooreiv@gmail.com> Co-authored-by: John Moore <john@flexcompute.com> Co-authored-by: Maciej Skarysz <83596707+maciej-flexcompute@users.noreply.github.com> Co-authored-by: Andrzej Krupka <156919532+andrzej-krupka@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.