Skip to content

[Hotfix-24.11] Add length unit property to project #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angranl-flex merged 1 commit into from
Feb 20, 2025
Merged

[Hotfix-24.11] Add length unit property to project #752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 23 additions & 15 deletions flow360/component/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,27 @@ def id(self) -> str:
"""
return self.metadata.id

@property
def length_unit(self) -> LengthType.Positive:
"""
Returns the length unit of the project.

Returns
-------
LengthType.Positive
The length unit.
"""

defaults = self._root_simulation_json

cache_key = "private_attribute_asset_cache"
length_key = "project_length_unit"

if cache_key not in defaults or length_key not in defaults[cache_key]:
raise Flow360ValueError("[Internal] Simulation params do not contain length unit info.")

return LengthType.validate(defaults[cache_key][length_key])

@property
def geometry(self) -> Geometry:
"""
Expand Down Expand Up @@ -599,21 +620,8 @@ def _run(
root asset (Geometry or VolumeMesh) is not initialized.
"""

defaults = self._root_simulation_json

cache_key = "private_attribute_asset_cache"
length_key = "project_length_unit"

if cache_key not in defaults:
if length_key not in defaults[cache_key]:
raise Flow360ValueError("Simulation params do not contain default length unit info")

length_unit = defaults[cache_key][length_key]

with model_attribute_unlock(params.private_attribute_asset_cache, length_key):
params.private_attribute_asset_cache.project_length_unit = LengthType.validate(
length_unit
)
with model_attribute_unlock(params.private_attribute_asset_cache, "project_length_unit"):
params.private_attribute_asset_cache.project_length_unit = self.length_unit

root_asset = self._root_asset

Expand Down