Skip to content

[SCFD-4702] added dimentioned velocity and pressure as user defined functions#833

Merged
maciej-flexcompute merged 9 commits intodevelopfrom
maciej/dimensioned_outputs
Mar 20, 2025
Merged

[SCFD-4702] added dimentioned velocity and pressure as user defined functions#833
maciej-flexcompute merged 9 commits intodevelopfrom
maciej/dimensioned_outputs

Conversation

@maciej-flexcompute
Copy link
Collaborator

@maciej-flexcompute maciej-flexcompute commented Mar 18, 2025 •
edited
Loading

https://flow360.atlassian.net/browse/SCFD-4702
added pre-defined fields that are converted to UDFs:

    "velocity",
    "velocity_magnitude",
    "pressure",
    "velocity_m_per_s",
    "velocity_magnitude_m_per_s",
    "velocity_x_m_per_s",
    "velocity_y_m_per_s",
    "velocity_z_m_per_s",
    "pressure_pa",
    "wall_shear_stress_magnitude",
    "wall_shear_stress_magnitude_pa",

Some alternative design:

class VelocityField(Flow360BaseModel):
    units: VelocityType = flow360_velocity_unit
    component: Optional[
        Union[Literal["x", "y", "z", "magnitude"], List[Literal["x", "y", "z", "magnitude"]]]
    ] = None

@maciej-flexcompute maciej-flexcompute changed the title added dimentioned velocity and pressure as user defined functions [SCFD-4702] added dimentioned velocity and pressure as user defined functions Mar 18, 2025
@maciej-flexcompute maciej-flexcompute marked this pull request as ready for review March 18, 2025 19:59
benflexcompute
benflexcompute reviewed Mar 19, 2025
View reviewed changes
@maciej-flexcompute maciej-flexcompute enabled auto-merge (squash) March 20, 2025 11:19
@maciej-flexcompute maciej-flexcompute merged commit 3242711 into develop Mar 20, 2025
15 checks passed
@maciej-flexcompute maciej-flexcompute deleted the maciej/dimensioned_outputs branch March 20, 2025 11:32
benflexcompute pushed a commit that referenced this pull request Mar 20, 2025
@maciej-flexcompute @benflexcompute
[SCFD-4702] added dimentioned velocity and pressure as user defined f…
61d0bbd 
…unctions (#833)

* added dimentioned velocity and pressure as user defined functions

* fixed linter

* fixed test

* fixed test

* addreed PR comments

* added missing file

* addressed comments

* linter fix
benflexcompute added a commit that referenced this pull request Mar 21, 2025
@benflexcompute @maciej-flexcompute
[SCFD-4702] added dimentioned velocity and pressure as user defined f…
5aec36c 
…unctions (#833) (#851)

* added dimentioned velocity and pressure as user defined functions

* fixed linter

* fixed test

* fixed test

* addreed PR comments

* added missing file

* addressed comments

* linter fix

Co-authored-by: Maciej Skarysz <83596707+maciej-flexcompute@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benflexcompute benflexcompute benflexcompute approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maciej-flexcompute @benflexcompute