Conversation
wiktor-flex
force-pushed
the
wiktor/drivaer
branch
from
021a945 to
a5cd3cb
Compare
piotrkluba
reviewed
Apr 18, 2025
Collaborator
piotrkluba
left a comment
piotrkluba
left a comment
There was a problem hiding this comment.
cases = []from cell 4 can be moved to cell 7- cell 13 - maybe solve that with some kind of dict so it is clearly visible which limit is applied to which camera, maybe just reformat so each tuple is in a different row and comment appropriate camera names next to it
- cell 14 - i would add parentheses to the mathematical expressions so the order of equations is more clear (but it is just how I like it) for example:
"(1/(2*totalCL)) - totalCMy" - cell 16 - maybe move the definitions of chart2D outside also for coherence
Text is written very well, descriptive yet concise, I liked it very much
wiktor-flex
force-pushed
the
wiktor/drivaer
branch
from
a5cd3cb to
f59fa89
Compare
piotrkluba
reviewed
Apr 23, 2025
Collaborator
piotrkluba
left a comment
piotrkluba
left a comment
There was a problem hiding this comment.
- Text before cell 4 was not modified when
cases = []was moved
wiktor-flex
force-pushed
the
wiktor/drivaer
branch
from
6f07b90 to
6ed2193
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notebook based on the automotive_report.py script
it includes an example 5.7m mesh as well as all parameters to run the case and generate the report