[SCFD-4733] [SCFD-5021] [Hotfix-RC25.2] Get the default reference geometry settings with the provided length unit #892
Merged
angranl-flex merged 6 commits intorelease-candidate/25.2from Apr 15, 2025
Conversation
Contributor
angranl-flex
commented
Apr 11, 2025
angranl-flex
commented
- Get default reference geometry settings with the provided length unit (https://flow360.atlassian.net/browse/SCFD-4733)
- Add the default reference geometry settings before uploading the simulation params.(https://flow360.atlassian.net/browse/SCFD-5021)
benflexcompute
approved these changes
Apr 15, 2025
angranl-flex
added a commit
that referenced
this pull request
Apr 15, 2025
…metry settings with the provided length unit (#892) * Change the unit of reference geometry in the default params * Encapsule the function to get default reference geometry * Set up default reference geometry's value if None * Update type hint for the get_default_params function * address comment
benflexcompute
pushed a commit
that referenced
this pull request
Apr 15, 2025
…ith the provided length unit (#892) (#905) * [SCFD-4733] [SCFD-5021] [Hotfix-RC25.2] Get the default reference geometry settings with the provided length unit (#892) * Change the unit of reference geometry in the default params * Encapsule the function to get default reference geometry * Set up default reference geometry's value if None * Update type hint for the get_default_params function * address comment * fix pylint
angranl-flex
added a commit
that referenced
this pull request
Apr 15, 2025
…metry settings with the provided length unit (#892) * Change the unit of reference geometry in the default params * Encapsule the function to get default reference geometry * Set up default reference geometry's value if None * Update type hint for the get_default_params function * address comment
angranl-flex
added a commit
that referenced
this pull request
Apr 15, 2025
…ometry settings with the provided length unit (#892) (#906) * Change the unit of reference geometry in the default params * Encapsule the function to get default reference geometry * Set up default reference geometry's value if None * Update type hint for the get_default_params function * address comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.