[FL-71][Hotfix RC-25.2] Improve Validation Error For MultiConstructor Model#921
Merged
benflexcompute merged 2 commits intorelease-candidate/25.2from Apr 21, 2025
Conversation
* added default name fields to all classes that appear on webUI * updated unittests based on the new default names * removed unnecessary to file
* Remove typo and unused parameter in BETDiskCache * Add function to convert multiconstructor validation error * Add unit test * Add function to update input cache * Address comments * fix unit test * formatting * fix unit test * Add name to the BETDiskCache * Add an unit test to test the extra input_cache key for the used constructor
benflexcompute
approved these changes
Apr 21, 2025
benflexcompute
deleted the
angran/hotfix252addValidationForMultiConstructor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove typo and unused parameter in BETDiskCache
Add function to convert multiconstructor validation error
Add unit test
Add function to update input cache
Address comments
fix unit test
formatting
fix unit test
Add name to the BETDiskCache
Add an unit test to test the extra input_cache key for the used constructor
Also includes the hotfix of #901