Skip to content

fix(tidy3d): FXC-5313 improve broadband frequency range warning message #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daquinteroflex merged 1 commit into from
Feb 4, 2026
Merged

fix(tidy3d): FXC-5313 improve broadband frequency range warning message #3223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_components/test_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def test_gaussian_from_frequency_range():
g2 = td.GaussianPulse.from_frequency_range(fmin=fmin, fmax=fmax)
assert g2.remove_dc_component

with AssertLogLevel("WARNING", contains_str="not sufficiently large"):
with AssertLogLevel("WARNING", contains_str="broadband"):
g_small = td.GaussianPulse.from_frequency_range(
fmin=fmin, fmax=60e9, remove_dc_component=True
)
Expand Down
4 changes: 2 additions & 2 deletions tidy3d/components/source/time.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,8 +389,8 @@ def from_frequency_range(
pulse = cls(freq0=freq0, fwidth=fwidth, **kwargs)
if np.abs(pulse._rel_amp_freq(fmin)) < WARN_SOURCE_AMPLITUDE:
log.warning(
"Source amplitude is not sufficiently large throughout the specified frequency range, "
"which can result in inaccurate simulation results. Please decrease the frequency range.",
"Default source time profile is less accurate for the specified broadband frequency range. "
"For more accurate results, consider reducing the frequency range or using a 'BroadbandSource'.",
)
return pulse

Expand Down
Loading