fix(tidy3d): FXC-5313 improve broadband frequency range warning message#3223
Merged
daquinteroflex merged 1 commit intodevelopfrom Feb 4, 2026
Merged
Conversation
Contributor
|
CHANGELOG entry? |
Collaborator
Author
it looks too minor to edit CHANGLOG |
weiliangjin2021
force-pushed
the
weiliang/FXC-5313-adjust-broadband-warning
branch
from
4274546 to
17c949b
Compare
Contributor
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changesNo lines with coverage information in this diff. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Only updates a warning string and adjusts the corresponding test expectation; no behavioral or numerical logic changes.
Overview
Improves the warning emitted by
GaussianPulse.from_frequency_rangewhen the default (DC-removed) Gaussian pulse is likely inaccurate for broadband frequency ranges, explicitly suggesting reducing the range or usingBroadbandSource.Updates the unit test to assert against the new warning text by matching on "broadband" instead of the previous "not sufficiently large" phrasing.
Written by Cursor Bugbot for commit 17c949b. This will update automatically on new commits. Configure here.