Skip to content

Some feature names collide with Action routes #80

@carlthuringer

Description

@carlthuringer

I ran into an issue implementing my first feature, refactor-images. The application would crash with a bizarre error: Flipper::UI::RequestMethodNotSupported - Flipper::UI::Actions::File does not support request method "post"
This happened when I tried to add a specific actor using the UI.

This made me think that I had broken it somehow, or otherwise set it up incorrectly, but my only mistake was treading upon A Regular Expression

I discovered my error by the expedient combo of debugging, stepping, and print @action_collection.method(:action_for_request).source. But of course I think more common consumers of the gem may be completely confused and give up or post an issue.

Shouldn't you specify the route match more strictly, rather than matching any part of the full path?

route %r{\a#{base_path}(images|css|js|octicons|fonts)/.*\Z}

Else, no features containing these five words will be permitted.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions