Merged
Conversation
Collaborator
Author
|
I think I should probably make this an adapter shared spec/test so we can catch this for all of them. |
Collaborator
Author
|
The sequel adapter also has this problem. I'll move this to a shared test/spec for all adapters and then merge it. |
In case anyone renamed a table for whatever reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the sequel and active record adapters to include even disabled features in get_all. The issue was using an inner join between feature and gate tables, which means features in the feature table but not in the gate table (because they were fully disabled) were not represented in get_all.
fixes #324