Skip to content

Iclass UI #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 5, 2022
Merged

Iclass UI #1366

merged 7 commits into from
Jul 5, 2022

Conversation

bettse
Copy link
Contributor

@bettse bettse commented Jul 4, 2022

What's new

  • Adds scene to Picopass plugin

Other notes:

  • This was heavily based on the NFC app
  • includes some storage references to set the stage for saving/downgrading to LF HID Prox
  • It is a shit ton of code, but the minimal amount I could do to replicate the existing functionality.
  • As always, let me know of any changes I need to make
  • ./fbt flash_usb --with-updater --extra-int-apps=picopass

Verification

  • Launch Picopass plugin
  • Select "Read Card"
  • Put Flipper near iClass credential
  • Hear chime, see success screen, see raw credential (and decoded if 26 bit)

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@bettse bettse marked this pull request as ready for review July 4, 2022 22:30
@RogueMaster

This comment was marked as abuse.

@ezhevita
Copy link
Contributor

ezhevita commented Jul 5, 2022

My pull request need mbedtls for nfc_protocols
anyway it's possible to reference one module from another, so I don't think it would be a problem

@skotopes
Copy link
Contributor

skotopes commented Jul 5, 2022

6380786 [I][LoaderSrv]: Application thread stopped. Free heap: 125664. Thread allocation balance: 88.
6381097 [I][AnimationManager]: Select 'L1_Furippa1_128x64' animation
6381101 [I][AnimationManager]: Load animation 'L1_Furippa1_128x64'
6381103 [I][SavedStruct]: Loading "/int/desktop.settings"
6394174 [I][LoaderSrv]: Starting: PicoPass Reader
6394180 [I][AnimationManager]: Unload animation 'L1_Furippa1_128x64'
6396180 [I][LoaderSrv]: Application thread stopped. Free heap: 125576. Thread allocation balance: 88.
6396492 [I][AnimationManager]: Select 'L1_Furippa1_128x64' animation
6396494 [I][AnimationManager]: Load animation 'L1_Furippa1_128x64'
6396496 [I][SavedStruct]: Loading "/int/desktop.settings"
6400567 [I][LoaderSrv]: Starting: PicoPass Reader
6400573 [I][AnimationManager]: Unload animation 'L1_Furippa1_128x64'
6401581 [I][LoaderSrv]: Application thread stopped. Free heap: 125488. Thread allocation balance: 88.

Leaking memory

@skotopes
Copy link
Contributor

skotopes commented Jul 5, 2022

missing picopass_device_free call

@skotopes
Copy link
Contributor

skotopes commented Jul 5, 2022

Please take a look on 487e1bc

Since C doesn't have namespaces we create them artificially by prefixing types and functions with package name.
I've cleaned up picopass application, but loclass lib is require some work.

@skotopes skotopes merged commit 8af2198 into flipperdevices:dev Jul 5, 2022
@bettse bettse deleted the iclass_ui branch July 5, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants