Process start, potentially migration: Signal scope gets ignored starting with the 2nd process #3921
Description
Describe the bug
If I start a process that has a Signal event definition and a Signal Start Event, starting it will work normally the first time.
The second time, the resulting event subscription's scope definition will always be "null", because the event definition's signal ref gets overwritten the first time.
Potentially, this may also affect process instance migrations (there are 2 places in the code where the behavior is like this).
Expected behavior
I expect the same behavior each time - the signalref stays as-is, the event subscription always gets created with the right scope.
Code
I prepared a Pull Request here: #3920
I would love to add regression tests as well, but I can't seem to find a good place.
Please point me to a "good" place where I can add a test method as a regression test.
Additional context
All that should matter is the flowable version.
I tried with 6.8.1 and 7.0.1, the bug is in both and seems to go back very far.
Workaround
Without a fix, the bug does not occur if Signal ID and name must are the same, e.g.
<bpmn:signal id="terminate_product" name="terminate_product" flowable:scope="processInstance" />