feat: add support for .mjs file output #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingnuclei
force-pushed
the
feature/mjs_file_output
branch
from
e11ec2b to
0080a7b
Compare
|
PR changed to be more configurable |
|
Hi @codingnuclei , thank you for the careful PR. I think it's a necessary addition. |
@floydspace This might be me being silly - but I am not seeing any comments? |
floydspace
requested changes
Jul 18, 2022
|
@codingnuclei oh I was not aware that comments are not visible unless a review is submitted, so it was silly from my side |
codingnuclei
force-pushed
the
feature/mjs_file_output
branch
from
0080a7b to
b799b34
Compare
|
@floydspace updated with your comments resolved :) |
floydspace
approved these changes
Jul 18, 2022
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey.
This PR adds outputting
.mjsfiles if the build optionplatform=neutral.Currently we can use
platform=neutralto output the bundle as esm. The bundle extension however remains.js. This is fine when it is accompanied by apackage.jsonwhich has"type": "module"set.However, the `package.json' is explicitly not included in the final zip.
https://github.com/floydspace/serverless-esbuild/blob/master/src/pack.ts#L38
This means that lambdas run the code as CommonJs.
Changing the file type seems a more explicit option (rather than package the
package.json)Considerations:
-platform=neutralnow outputs.mjsfilesNotes on testing
buildOptionsin tests. I have therefore casted when added to the overrides. Keeping the variable typed should ensure the type safety.First PR to serverless-esbuild so let me know if you require anything else.
Partially closes #315 (
package.jsonis no longer required)Update
Have updated so that
.jsis the default extension thereby making this a none breaking change.If you wish to change the extension you can now use the new
outputFileExtensionwhich has some validation to keep the user right.